chore(requires-writer): update auto-generated code to not trigger no-mixed-operators eslint warnings/errors #26356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mixed-operators eslint warnings/errors
gatsbot
bot
added
the
status: triage needed
Gatsby Cloud Build Report🚩 Your build failed. See the build logs here Errors Error in "/usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/gatsby-node.js": Cannot find module 'gatsby-cli/lib/reporter' Require stack: - /usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/is-valid-collection-path-implementation.js - /usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/create-pages-from-collection-builder.js - /usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/create-page-wrapper.js - /usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/gatsby-node.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/resolve-module-exports.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/load-plugins/validate.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/load-plugins/load.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/load-plugins/index.js - /usr/src/app/www/www/node_modules/gatsby/dist/services/initialize.js - /usr/src/app/www/www/node_modules/gatsby/dist/services/index.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/index.js - /usr/src/app/www/www/node_modules/gatsby/dist/commands/build.js - /usr/src/app/www/www/node_modules/gatsby/node_modules/gatsby-cli/lib/create-cli.js - /usr/src/app/www/www/node_modules/gatsby/node_modules/gatsby-cli/lib/index.js - /usr/src/app/www/www/node_modules/gatsby/dist/bin/gatsby.js - /usr/src/app/www/www/node_modules/gatsby/cli.js |
Gatsby Cloud Build Report🚩 Your build failed. See the build logs here Errors Error in "/usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/gatsby-node.js": Cannot find module 'gatsby-cli/lib/reporter' Require stack: - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/is-valid-collection-path-implementation.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/create-pages-from-collection-builder.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/create-page-wrapper.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/gatsby-node.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/resolve-module-exports.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/load-plugins/validate.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/load-plugins/load.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/load-plugins/index.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/services/initialize.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/services/index.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/index.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/commands/build.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/node_modules/gatsby-cli/lib/create-cli.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/node_modules/gatsby-cli/lib/index.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bin/gatsby.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/cli.js |
pieh
added
topic: webpack/babel
pvdz
reviewed
Aug 11, 2020
| @@ -195,7 +195,7 @@ export const writeAll = async (state: IGatsbyState): Promise<boolean> => { | |||
| let syncRequires = `${hotImport} | |||
|
|
|||
| // prefer default export if available | |||
| const preferDefault = m => m && m.default || m | |||
| const preferDefault = m => (m && m.default) || m | |||
There was a problem hiding this comment.
I guess in the future this will be
Suggested change
| const preferDefault = m => (m && m.default) || m | |
| const preferDefault = m => m?.default ?? m |
There was a problem hiding this comment.
In this case I'm not sure which one is more readable :)
But I think we could use your suggestions because this file should be handled by babel so both optional chaining and nullish coalescing operator should work just fine (tho users do have option to use their own custom babel config, so probably keeping old style would result in less potential for problems)
There was a problem hiding this comment.
Old syntax is less bytes when transpiled
pvdz
approved these changes
Aug 11, 2020
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code we generate in
(a)sync-requires.js(virtual) modules currently doesn't passno-mixed-operatorseslint rule. This is quick change to make it pass. This is for cases when users might use some custom eslint setups (tho I probably should follow up and see if we have documentation foreslint-loadermodifications anywhere and possibly adjustignoresetting there to ignore modules from_this_is_virtual_fs_path_/$virtual(as user might have very speciffic rules that would warn/error on code we autogenerate)Related Issues
Fixes #26319