-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): remove remaining spectrum references #26389
chore(docs): remove remaining spectrum references #26389
Conversation
Hey, @taylorcjohnson! Thanks for following up on this! I generally prefer not to mess with blog posts once they've been published but I'll tag @mgienow in here for the final word. Once she's made a call, one way or the other, I'll be happy to review this. |
Sounds great @AishaBlake - that completely makes sense. Looks like the build failed due to dependency issues anyway (not sure why exactly), so I may wait until the final verdict and start over with a fresh fork 🤷? Apologies for the triple reviewer request! Didn't realize GitHub would automatically add those maintainer groups with you already in them! 🤦 |
personally i would expect that blogpost get updated with with small bug fixes or generic information changes like the spectrum link. |
In this specific case, yes, I'd agree. Regardless, I'd like to run this by Michelle. @taylorcjohnson, I appreciate you breaking this up into the two commits. Either way, this should be a smooth change! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to @mgienow and while doing that realized that the blog posts are stored in WordPress now anyways (the live ones), so changing the markdown files here only helps when people browse the repository on their own.
I'll file an internal ticket to update the posts in WordPress. I also replaced Spectrum with our AskGatsbyJS twitter account in both READMEs
Co-authored-by: Lennart <lekoarts@gmail.com>
Description
This PR attempts to remove remaining references to the Gatsby Spectrum community in documentation. Currently, it is separated into two commits:
Removing Spectrum from contributing and README files
Removing Spectrum from #100DaysOfGatsby blog series
I have two outstanding questions:
Is it appropriate for this PR to remove the Spectrum reference from already published blog posts (i.e., the second commit)?
If so, there are two additional blogs posts (not yet included in the PR) where Chris Biscardi introduces Gatsby themes and specifically discusses the
gatsby-themes
channel in Spectrum (not simply linking out to them) - could someone suggest how (or if) I should modify these? Thank you in advance!Documentation
Not applicable - this PR does not change/add any code that would require documentation
Related Issues
Fixes #26351