Make optional SVG favicon come after the fallback #27843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gatsbyjs#26083 Chrome choosing the favicon which comes last.
gatsbot
bot
added
the
status: triage needed
|
@moonmeister I did end up needing to update the snapshots, and managed to get all tests passing locally. Seems like there are a couple of tests here that are still failing though— My feeling is that these are unrelated to the changes that I made in this PR, but I'm wondering what your thoughts are. Does this look ok to merge as-is, or is there something I should do to make these tests pass? |
ascorbic
added
topic: plugins-PWA
ascorbic
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
lgtm, but @moonmeister if you could take a quick glance when you have the chance that'd be good
|
@trevorblades Yes, those are unrelated |
moonmeister
approved these changes
Nov 5, 2020
|
All good |
|
@moonmeister @ascorbic is there anything blocking this PR from being merged/released? 😇 |
moonmeister
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extension of #27566, with the requested changes from #27566 (review)