feat(gatsby): make dev ssr bundling lazy #28149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
added
topic: resource loading*
and removed
status: triage needed
KyleAMathews
commented
Nov 19, 2020
| await getPageDataExperimental(pageObj.path) | ||
|
|
||
| // Wait for public/render-page.js to update w/ the page component. | ||
| await ensurePathComponentInSSRBundle(pageObj, directory) |
There was a problem hiding this comment.
this function is the meat of the change
KyleAMathews
added a commit
that referenced
this pull request
Nov 19, 2020
gatsbybot
pushed a commit
that referenced
this pull request
Nov 19, 2020
vladar
pushed a commit
that referenced
this pull request
Nov 19, 2020
gatsbybot
pushed a commit
to gatsbyjs/gatsby-starter-mdx-basic
that referenced
this pull request
Nov 19, 2020
…186) * fix(gatsby): pull out a few bug fixes from gatsbyjs/gatsby#28149 * Add missing fix
gatsbybot
pushed a commit
to gatsbyjs/gatsby-starter-notes-theme
that referenced
this pull request
Nov 19, 2020
…186) * fix(gatsby): pull out a few bug fixes from gatsbyjs/gatsby#28149 * Add missing fix
gatsbybot
pushed a commit
to gatsbyjs/gatsby-starter-theme
that referenced
this pull request
Nov 19, 2020
…186) * fix(gatsby): pull out a few bug fixes from gatsbyjs/gatsby#28149 * Add missing fix
gatsbybot
pushed a commit
to gatsbyjs/gatsby-starter-hello-world
that referenced
this pull request
Nov 19, 2020
…186) * fix(gatsby): pull out a few bug fixes from gatsbyjs/gatsby#28149 * Add missing fix
vladar
added a commit
that referenced
this pull request
Nov 19, 2020
vladar
reviewed
Nov 23, 2020
vladar
approved these changes
Nov 23, 2020
This was referenced Jul 23, 2022
This was referenced Jul 23, 2022
This was referenced Jul 23, 2022
This was referenced Jul 26, 2022
This was referenced Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to lazy client bundling PR #27884
Saves a significant amount of time on bootup