Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): pull out a few bug fixes from https://github.com/gatsbyjs/gatsby/pull/28149/ #28186

Merged
merged 2 commits into from
Nov 19, 2020
Merged

fix(gatsby): pull out a few bug fixes from https://github.com/gatsbyjs/gatsby/pull/28149/ #28186

merged 2 commits into from
Nov 19, 2020

Conversation

KyleAMathews
Copy link
Contributor

  • typo on env var
  • make sure page-data.json is created before SSRing

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 19, 2020
wardpeet
wardpeet previously approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pieh
pieh approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vladar vladar added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 19, 2020
@gatsbybot gatsbybot merged commit f9fd11d into master Nov 19, 2020
vladar pushed a commit that referenced this pull request Nov 19, 2020
@KyleAMathews @vladar
fix(gatsby): pull out a few bug fixes from #28149 (#28186)
e618e4b 
* fix(gatsby): pull out a few bug fixes from #28149

* Add missing fix

(cherry picked from commit f9fd11d)
@vladar vladar mentioned this pull request Nov 19, 2020
Merged
vladar added a commit that referenced this pull request Nov 19, 2020
@vladar @KyleAMathews
fix(gatsby): pull out a few bug fixes from #28149 (#28186) (#28188)
a5131bd 
* fix(gatsby): pull out a few bug fixes from #28149

* Add missing fix

(cherry picked from commit f9fd11d)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
@LekoArts LekoArts deleted the sall-ssr-fixes branch April 23, 2021 11:07
@kaocher82 kaocher82 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Jul 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@wardpeet wardpeet wardpeet left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleAMathews @pieh @wardpeet @vladar @gatsbybot