fix shopify source store url check #32003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
sslotsky
approved these changes
Jun 21, 2021
DanielSLew
added
topic: source-shopify
|
Can you please fill out the PR description? |
vladar
pushed a commit
that referenced
this pull request
Jun 22, 2021
(cherry picked from commit 92346b7)
vladar
pushed a commit
that referenced
this pull request
Jun 22, 2021
This was referenced Jun 23, 2021
This was referenced Jan 18, 2022
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added a regex check to make sure the store URL is what we expected and give better error messages for the users but forgot to allow numbers the URL. This PR adds
0-9to the allowed characters in the store name.Documentation
Related Issues