Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-source-shopify): removed apikey references/usage from shopify plugin #32024

Merged
merged 1 commit into from
Jun 22, 2021
Merged

feat(gatsby-source-shopify): removed apikey references/usage from shopify plugin #32024

merged 1 commit into from
Jun 22, 2021

Conversation

DanielSLew
Copy link
Contributor

Description

Documentation

The usage of apiKey is no longer required, we can get rid of references of it and remove it from being required in the plugin options. This gives us more flexibility as we no longer need to obtain an api key when setting up a user's site.

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 22, 2021
@DanielSLew DanielSLew added the topic: source-shopify Related to the gatsby-source-shopify plugin label Jun 22, 2021
@DanielSLew DanielSLew added this to To cherry-pick in V3 Release Hotfixes via automation Jun 22, 2021
@DanielSLew DanielSLew changed the title removed apikey references/usage from shopify plugin feat(gatsby-source-shopify): removed apikey references/usage from shopify plugin Jun 22, 2021
@DanielSLew DanielSLew removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 22, 2021
@DanielSLew DanielSLew merged commit 47cf675 into master Jun 22, 2021
@DanielSLew DanielSLew deleted the remove-apikey-usage-from-shopify-plugin branch June 22, 2021 14:59
@DanielSLew DanielSLew added this to To cherry-pick in Release candidate via automation Jun 22, 2021
@DanielSLew DanielSLew removed this from To cherry-pick in V3 Release Hotfixes Jun 22, 2021
@gatsbybot gatsbybot mentioned this pull request Jun 22, 2021
Merged
vladar pushed a commit that referenced this pull request Jun 22, 2021
@DanielSLew @vladar
removed apikey references/usage from shopify plugin (#32024)
bd14a06 
(cherry picked from commit 47cf675)
@vladar vladar moved this from To cherry-pick to Backport PR opened in Release candidate Jun 22, 2021
gatsbybot pushed a commit that referenced this pull request Jun 22, 2021
@DanielSLew
removed apikey references/usage from shopify plugin (#32024) (#32033)
549cca9 
(cherry picked from commit 47cf675)

Co-authored-by: Daniel Lew <51924260+DanielSLew@users.noreply.github.com>
@vladar vladar moved this from Backport PR opened to Backported in Release candidate Jun 22, 2021
This was referenced Jun 23, 2021
Open
Open
Open
Open
This was referenced Jan 18, 2022
Open
Open
@0xSebin 0xSebin mentioned this pull request Jun 22, 2022
Open
@monizb monizb mentioned this pull request Oct 27, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Oct 27, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Oct 27, 2023
Open
@impactyogi impactyogi mentioned this pull request Oct 27, 2023
Open
@wizbit wizbit mentioned this pull request Oct 27, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Oct 28, 2023
Open
@saurabharch saurabharch mentioned this pull request Oct 28, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Dec 14, 2023
Open
@monizb monizb mentioned this pull request Dec 14, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Dec 14, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Dec 14, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 15, 2023
Open
@wizbit wizbit mentioned this pull request Dec 15, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 15, 2023
Open
@saurabharch saurabharch mentioned this pull request Dec 15, 2023
Open
@wizbit wizbit mentioned this pull request Dec 15, 2023
Open
@joeawillis joeawillis mentioned this pull request Dec 15, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 15, 2023
Open
@saurabharch saurabharch mentioned this pull request Dec 15, 2023
Open
@joeawillis joeawillis mentioned this pull request Dec 15, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jan 5, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 5, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 5, 2024
Open
@monizb monizb mentioned this pull request Jan 5, 2024
Open
@impactyogi impactyogi mentioned this pull request Jan 5, 2024
Open
@wizbit wizbit mentioned this pull request Jan 5, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
This was referenced Jan 6, 2024
Open
Open
@saurabharch saurabharch mentioned this pull request Jan 6, 2024
Open
@monizb monizb mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 6, 2024
Open
@saurabharch saurabharch mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sslotsky sslotsky sslotsky approved these changes

Assignees
No one assigned
Labels
topic: source-shopify Related to the gatsby-source-shopify plugin
Projects
No open projects
Release candidate
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielSLew @sslotsky