refactor(contentful): migrate to schema customization API #32351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g dominat color or tracing svg
axe312ger
added
the
topic: source-contentful
axe312ger
added this to In progress
in Contentful source plugin improvements
via automation
gatsbot
bot
added
the
status: triage needed
axe312ger
commented
Jul 13, 2021
| @@ -1,30 +1,19 @@ | |||
| const path = require(`path`) | |||
| const isOnline = require(`is-online`) | |||
| // @todo import syntax! | |||
There was a problem hiding this comment.
reminder to myself: time to finally get all files to es-module syntax
axe312ger
commented
Jul 13, 2021
| @@ -1,30 +1,19 @@ | |||
| const path = require(`path`) | |||
| const isOnline = require(`is-online`) | |||
| // @todo import syntax! | |||
There was a problem hiding this comment.
reminder to myself: time to finally get all files to es-module syntax
axe312ger
commented
Jul 13, 2021
|
|
||
| // If the cache has data, use it. Otherwise do a remote fetch anyways and prime the cache now. | ||
| // If present, do NOT contact contentful, skip the round trips entirely | ||
| if (forceCache) { |
There was a problem hiding this comment.
This experimental flag adds some complexity to this code we could avoid.
I can't find any documentation to it as well
axe312ger
commented
Jul 13, 2021
| } | ||
| }) | ||
|
|
||
| // @todo based on the sys metadata we should be able to differentiate new and updated entities |
There was a problem hiding this comment.
should be low effort, also pretty low impact on the whole build time
axe312ger
commented
Jul 13, 2021
| } | ||
| }) | ||
|
|
||
| // @todo based on the sys metadata we should be able to differentiate new and updated entities |
There was a problem hiding this comment.
should be low effort, also pretty low impact on the whole build time
axe312ger
commented
Jul 13, 2021
| // Remove deleted entries & assets | ||
| reporter.verbose(`Removing deleted Contentful entries & assets`) | ||
|
|
||
| // @todo this should happen when sourcing? |
There was a problem hiding this comment.
IMHO any interaction with actual nodes should happen in source-nodes. WDYT?
axe312ger
commented
Jul 13, 2021
| } | ||
| }) | ||
|
|
||
| const creationActivity = reporter.activityTimer( |
There was a problem hiding this comment.
@todo consider including all the map creation and loops in the creation activity.
axe312ger
commented
Jul 13, 2021
|
|
||
| // A contentType can hold lots of entries which create nodes | ||
| // We wait until all nodes are created and processed until we handle the next one | ||
| // TODO add batching in gatsby-core |
There was a problem hiding this comment.
@wardpeet do we have any kind of new API that could help here? That comment is for sure very old
axe312ger
commented
Jul 13, 2021
|
|
||
| creationActivity.end() | ||
|
|
||
| // @todo add own activity! |
axe312ger
added
the
type: maintenance
LekoArts
removed
the
status: triage needed
axe312ger
moved this from In progress
to On Hold
in Contentful source plugin improvements
2 tasks
wardpeet
force-pushed
the
refactor/contentful-asset-dowloading
branch
from
e01c0f0
to
e955764
Compare
wardpeet
force-pushed
the
refactor/contentful-asset-dowloading
branch
2 times, most recently
from
2ae4698
to
3f686a0
Compare
axe312ger
force-pushed
the
refactor/contentful-asset-dowloading
branch
from
f441cb3
to
8bda979
Compare
5 tasks
axe312ger
deleted the
refactor/contentful-use-schema-customization-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin filled up
sourceNodeswith a bunch of things. This PR cleans this up, moves large chunks of the code in separate files and their correct GatsbyJS API hooks.Current status:
gatsby-node.jsstill need to be refactored. This might be a great time to restructure these huge fixture json files?