-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby-source-contentful): clean up code base and introduce es-module syntax #33213
Merged
wardpeet
merged 3 commits into
master
from
refactor/prepare-contentful-for-gatsby-v4-import-syntax
Oct 13, 2021
Merged
chore(gatsby-source-contentful): clean up code base and introduce es-module syntax #33213
wardpeet
merged 3 commits into
master
from
refactor/prepare-contentful-for-gatsby-v4-import-syntax
Oct 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Sep 16, 2021
axe312ger
changed the title
Refactor/prepare contentful for gatsby v4 import syntax
Contentful: clean up code base and introduce es-module syntax
Sep 16, 2021
5 tasks
axe312ger
force-pushed
the
refactor/prepare-contentful-for-gatsby-v4-import-syntax
branch
from
September 17, 2021 12:27
32ca839
to
2357180
Compare
axe312ger
added
topic: source-contentful
Related to Gatsby's integration with Contentful
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Sep 17, 2021
axe312ger
force-pushed
the
refactor/prepare-contentful-for-gatsby-v4
branch
from
September 24, 2021 08:24
a607dd1
to
80f3df8
Compare
axe312ger
force-pushed
the
refactor/prepare-contentful-for-gatsby-v4-import-syntax
branch
from
September 24, 2021 09:57
2357180
to
9c94e71
Compare
axe312ger
force-pushed
the
refactor/prepare-contentful-for-gatsby-v4
branch
2 times, most recently
from
September 25, 2021 12:14
573bc2b
to
97cacdf
Compare
axe312ger
force-pushed
the
refactor/prepare-contentful-for-gatsby-v4-import-syntax
branch
from
September 25, 2021 12:42
9c94e71
to
31b13a1
Compare
wardpeet
reviewed
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks but if tests are green, this is good to merge after big refactor is merged in
packages/gatsby-source-contentful/src/download-contentful-assets.js
Outdated
Show resolved
Hide resolved
wardpeet
force-pushed
the
refactor/prepare-contentful-for-gatsby-v4
branch
from
October 12, 2021 20:14
f49eaf9
to
4f22ccf
Compare
Base automatically changed from
refactor/prepare-contentful-for-gatsby-v4
to
master
October 13, 2021 07:10
axe312ger
force-pushed
the
refactor/prepare-contentful-for-gatsby-v4-import-syntax
branch
from
October 13, 2021 10:27
01ff64a
to
8c51126
Compare
Co-authored-by: Ward Peeters <ward@coding-tech.com>
axe312ger
force-pushed
the
refactor/prepare-contentful-for-gatsby-v4-import-syntax
branch
from
October 13, 2021 16:01
6e86090
to
e1c0f3e
Compare
wardpeet
approved these changes
Oct 13, 2021
wardpeet
changed the title
Contentful: clean up code base and introduce es-module syntax
chore(gatsby-source-contentful): clean up code base and introduce es-module syntax
Oct 13, 2021
wardpeet
deleted the
refactor/prepare-contentful-for-gatsby-v4-import-syntax
branch
October 13, 2021 16:36
wardpeet
added a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
…module syntax (gatsbyjs#33213) Co-authored-by: Ward Peeters <ward@coding-tech.com>
axe312ger
added a commit
that referenced
this pull request
Nov 9, 2021
…module syntax (#33213) Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is maintenance PR and a replacement for #32351 and should be merged after #33207