Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-source-contentful): clean up code base and introduce es-module syntax #33213

Merged

Conversation

axe312ger
Copy link
Collaborator

@axe312ger axe312ger commented Sep 16, 2021

This is maintenance PR and a replacement for #32351 and should be merged after #33207

  • applies ts-check
  • moves code to es-module syntax
  • improves some variable names

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 16, 2021
@axe312ger axe312ger changed the title Refactor/prepare contentful for gatsby v4 import syntax Contentful: clean up code base and introduce es-module syntax Sep 16, 2021
@axe312ger axe312ger force-pushed the refactor/prepare-contentful-for-gatsby-v4-import-syntax branch from 32ca839 to 2357180 Compare September 17, 2021 12:27
@axe312ger axe312ger added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 17, 2021
@axe312ger axe312ger force-pushed the refactor/prepare-contentful-for-gatsby-v4 branch from a607dd1 to 80f3df8 Compare September 24, 2021 08:24
@axe312ger axe312ger force-pushed the refactor/prepare-contentful-for-gatsby-v4-import-syntax branch from 2357180 to 9c94e71 Compare September 24, 2021 09:57
@axe312ger axe312ger force-pushed the refactor/prepare-contentful-for-gatsby-v4 branch 2 times, most recently from 573bc2b to 97cacdf Compare September 25, 2021 12:14
@axe312ger axe312ger self-assigned this Sep 25, 2021
@axe312ger axe312ger force-pushed the refactor/prepare-contentful-for-gatsby-v4-import-syntax branch from 9c94e71 to 31b13a1 Compare September 25, 2021 12:42
@axe312ger axe312ger marked this pull request as ready for review September 25, 2021 12:43
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks but if tests are green, this is good to merge after big refactor is merged in

@wardpeet wardpeet force-pushed the refactor/prepare-contentful-for-gatsby-v4 branch from f49eaf9 to 4f22ccf Compare October 12, 2021 20:14
Base automatically changed from refactor/prepare-contentful-for-gatsby-v4 to master October 13, 2021 07:10
@axe312ger axe312ger force-pushed the refactor/prepare-contentful-for-gatsby-v4-import-syntax branch from 01ff64a to 8c51126 Compare October 13, 2021 10:27
@axe312ger axe312ger force-pushed the refactor/prepare-contentful-for-gatsby-v4-import-syntax branch from 6e86090 to e1c0f3e Compare October 13, 2021 16:01
@wardpeet wardpeet changed the title Contentful: clean up code base and introduce es-module syntax chore(gatsby-source-contentful): clean up code base and introduce es-module syntax Oct 13, 2021
@wardpeet wardpeet merged commit 86f6645 into master Oct 13, 2021
@wardpeet wardpeet deleted the refactor/prepare-contentful-for-gatsby-v4-import-syntax branch October 13, 2021 16:36
wardpeet added a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
…module syntax (gatsbyjs#33213)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
axe312ger added a commit that referenced this pull request Nov 9, 2021
…module syntax (#33213)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants