-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3024 Exclude 404 pages from sitemap #3239
#3024 Exclude 404 pages from sitemap #3239
Conversation
Deploy preview ready! Built with commit 6aeb0c4 |
Deploy preview ready! Built with commit ad8d832 |
@KyleAMathews would be good to add sitemap plugin into preview site cause now sitemap.xml is not generated... and not possible to verify if on preview server are 404 gone |
nice! Thanks for tackling this! I just updated this PR with the latest code from master as there's some fixes to the preview build but gatsbyjs.org has also has previews built that we can look at its preview at https://deploy-preview-3239--gatsbyjs.netlify.com/sitemap.xml |
Hrmmm not sure why the preview stuff isn't working. Ran this locally on the gatsbyjs.org site and it worked so 🤷♂️ guess it's working |
Hiya @jurosh! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
Hey @jlengstorf I like to be part of such great product :) Thanks From Gatsby swag I like t-Shirts, but currently no M size, will you have those in future ? |
@jurosh we'll have shirts back in stock the first or second week of March. For the invite, can you try visiting https://github.com/orgs/gatsbyjs/invitation? If you don't see it, let me know. |
More details #3024
I had to use regex as it was not possible to do with simple path matching as was initially.
Regex contains negative look-ahead.
Now all paths starting with
404
&dev-404-page
are automatically filtered out.