Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3024 Exclude 404 pages from sitemap #3239

Merged
merged 3 commits into from
Dec 16, 2017

Conversation

jurosh
Copy link
Contributor

@jurosh jurosh commented Dec 16, 2017

More details #3024

I had to use regex as it was not possible to do with simple path matching as was initially.
Regex contains negative look-ahead.

Now all paths starting with 404 & dev-404-page are automatically filtered out.

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 6aeb0c4

https://deploy-preview-3239--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 16, 2017

Deploy preview ready!

Built with commit ad8d832

https://deploy-preview-3239--gatsbygram.netlify.com

@jurosh
Copy link
Contributor Author

jurosh commented Dec 16, 2017

@KyleAMathews would be good to add sitemap plugin into preview site cause now sitemap.xml is not generated... and not possible to verify if on preview server are 404 gone

@ghost ghost assigned KyleAMathews Dec 16, 2017
@ghost ghost added the review label Dec 16, 2017
@KyleAMathews
Copy link
Contributor

nice! Thanks for tackling this!

I just updated this PR with the latest code from master as there's some fixes to the preview build but gatsbyjs.org has also has previews built that we can look at its preview at https://deploy-preview-3239--gatsbyjs.netlify.com/sitemap.xml

@KyleAMathews
Copy link
Contributor

Hrmmm not sure why the preview stuff isn't working. Ran this locally on the gatsbyjs.org site and it worked so 🤷‍♂️ guess it's working

@KyleAMathews KyleAMathews merged commit 28eb597 into gatsbyjs:master Dec 16, 2017
@ghost ghost removed the review label Dec 16, 2017
@jlengstorf
Copy link
Contributor

Hiya @jurosh! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

@jurosh
Copy link
Contributor Author

jurosh commented Feb 23, 2019

Hey @jlengstorf I like to be part of such great product :) Thanks

From Gatsby swag I like t-Shirts, but currently no M size, will you have those in future ?
Btw. I am not part of Gatsby organization and also cannot see your invite yet - can you try to re-send ?

@jlengstorf
Copy link
Contributor

@jurosh we'll have shirts back in stock the first or second week of March. For the invite, can you try visiting https://github.com/orgs/gatsbyjs/invitation?

If you don't see it, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants