Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fix unit_tests_node14_lmdb_store tests #33257

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 20, 2021

Description

kriszyp/weak-lru-cache@4f3a59d is not handled by jest module resolution (both on version we use in repo as well as in latest jest), so this adds a workaround for it

Changing just jest.config file doesn't actually result in running tests - so here's example workflow with those changes - https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/74106/workflows/6225c8e5-ca73-442d-83ee-e0b1f452e290 (unit_tests_node14_lmdb_store is passing there)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 20, 2021
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 20, 2021
@pieh pieh changed the title [do-not-merge] [do-not-merge] troubleshooting unit_tests_node14_lmdb_store tests Sep 20, 2021
@pieh pieh force-pushed the tests/lmdb_store branch 2 times, most recently from 281b488 to 2dd8632 Compare September 20, 2021 15:17
@pieh pieh changed the title [do-not-merge] troubleshooting unit_tests_node14_lmdb_store tests fix(tests): fix unit_tests_node14_lmdb_store tests Sep 20, 2021
@pieh pieh marked this pull request as ready for review September 20, 2021 15:17
@wardpeet wardpeet merged commit d03fe39 into master Sep 20, 2021
@wardpeet wardpeet deleted the tests/lmdb_store branch September 20, 2021 16:42
wardpeet pushed a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants