Contentful: respect gatsby-plugin-image defaults and extend tests #33536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axe312ger
added
the
topic: source-contentful
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
|
Bump |
wardpeet
reviewed
Oct 29, 2021
Base automatically changed from
refactor/contentful-remove-gatsby-image-support
to
master
November 8, 2021 10:07
axe312ger
force-pushed
the
fix/contentful-respect-gatsby-plugin-image-defaults
branch
from
caa6428
to
b0ec8ca
Compare
axe312ger
force-pushed
the
fix/contentful-respect-gatsby-plugin-image-defaults
branch
from
861a735
to
4582656
Compare
axe312ger
added
the
status: needs core review
2 tasks
axe312ger
force-pushed
the
fix/contentful-respect-gatsby-plugin-image-defaults
branch
2 times, most recently
from
b620934
to
424277c
Compare
wardpeet
added
bot: merge on green
wardpeet
reviewed
Jan 28, 2022
Comment on lines
263
to
266
| const { | ||
| getPluginOptions, | ||
| doMergeDefaults, | ||
| } = require(`gatsby-plugin-sharp/plugin-options`) |
There was a problem hiding this comment.
We can't do this, it breaks PNP support
There was a problem hiding this comment.
switched to await import. This should do the trick?
wardpeet
removed
the
bot: merge on green
wardpeet
reviewed
Jan 31, 2022
Comment on lines
+263
to
+268
| const { getPluginOptions, doMergeDefaults } = await import( | ||
| `gatsby-plugin-sharp/plugin-options` | ||
| ) |
There was a problem hiding this comment.
This still breaks PNP support :D you can't import if it's not a peerdependency
There was a problem hiding this comment.
@wardpeet gatsby-plugin-sharp is a peer dependency already https://github.com/gatsbyjs/gatsby/blob/fix/contentful-respect-gatsby-plugin-image-defaults/packages/gatsby-source-contentful/package.json#L48
axe312ger
force-pushed
the
fix/contentful-respect-gatsby-plugin-image-defaults
branch
from
41b59c9
to
13fb9bc
Compare
wardpeet
approved these changes
May 20, 2022
axe312ger
removed
the
status: needs core review
axe312ger
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported via #31856 by @njbmartin, rebased version of #32802 based on #33528.
With these changes, we will respect the defaults of gatsby-plugin-image. Additionally, we will have proper tests for all placeholders.