Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(gatsby): Assert 301 redirects in E2E Tests #34554

Merged
merged 7 commits into from Jan 26, 2022
Merged

test(gatsby): Assert 301 redirects in E2E Tests #34554

merged 7 commits into from Jan 26, 2022

Conversation

marvinjude
Copy link
Contributor

@marvinjude marvinjude commented Jan 21, 2022 •
edited by LekoArts

Description

Assert visits and redirects for all trailing slash options

Contains #34590

Related Issues

[sc-44824]
[sc-44582]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 21, 2022
@marvinjude marvinjude changed the title fix(gatsbyApply trailingSlash express middleware more fine-grained fix(gatsby) : Apply trailingSlash express middleware more fine-grained Jan 21, 2022
@marvinjude marvinjude changed the title fix(gatsby) : Apply trailingSlash express middleware more fine-grained fix(gatsby) : Apply trailingSlash express middleware in fine-grained manner Jan 21, 2022
@marvinjude marvinjude changed the title fix(gatsby) : Apply trailingSlash express middleware in fine-grained manner test(gatsby) : Assert 301 redirects in E2E Tests Jan 21, 2022
@marvinjude marvinjude changed the title test(gatsby) : Assert 301 redirects in E2E Tests test(gatsby): Assert 301 redirects in E2E Tests Jan 24, 2022
@marvinjude marvinjude force-pushed the trailing-slash-express-middleware-fix branch from bd349ff to 3b9c8bb Compare January 24, 2022 08:33
@marvinjude marvinjude removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 24, 2022
LekoArts
LekoArts suggested changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to have the assertions on every direct visit test case, not only the first one :)

@LekoArts LekoArts mentioned this pull request Jan 26, 2022
Merged
13 tasks
@LekoArts LekoArts added this to the Trailing Slash milestone Jan 26, 2022
@LekoArts LekoArts merged commit 8f034c6 into trailing-slash Jan 26, 2022
@LekoArts LekoArts deleted the trailing-slash-express-middleware-fix branch January 26, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh left review comments

@imjoshin imjoshin imjoshin left review comments

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Trailing Slash
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marvinjude @pieh @imjoshin @LekoArts