trailing slashes - assert functions and static resources responses #34590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
commented
Jan 25, 2022
pieh
force-pushed
the
trailing-slash-assertions-for-functions-and-static
branch
from
d4012f8
to
472b137
Compare
pieh
removed
the
status: triage needed
LekoArts
approved these changes
Jan 26, 2022
LekoArts
deleted the
trailing-slash-assertions-for-functions-and-static
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds several tests for requests not targeting Gatsby pages (API functions and just
staticdir resources which we just copy topublic). We should make sure that trailing slashes changes (and options) don't change behaviour for those.