Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-cli): Resolve babel preset ts explicitly #35153

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Mar 17, 2022

Description

Due to babel/babel-loader#166 (comment), Babel can't access the TS preset unless resolved explicitly.

Reason for this is in create-gatsby we require handlers from gatsby-cli (presumably to avoid adding Babel deps to create-gatsby since they may not be needed if customers don't select plugins in the questionnaire [?]) and as a result of the above issue Babel isn't aware of the preset available in gatsby-cli.

Validated locally by pointing create-gatsby to my fork of gatsby-starter-minimal-ts with the patch applied - https://github.com/tyhopp/gatsby-starter-minimal-ts.

This will need to be released as a patch before #35128 can be merged

Documentation

No new docs needed

Related Issues

[sc-47001]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 17, 2022
@LekoArts LekoArts added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 17, 2022
@LekoArts LekoArts added this to To cherry-pick in V4 Release hotfixes via automation Mar 17, 2022
@LekoArts LekoArts merged commit 30ecc7d into master Mar 17, 2022
@LekoArts LekoArts deleted the fix/gatsby-cli-add-plugins-ts-preset-resoltion branch March 17, 2022 10:58
gatsbybot pushed a commit that referenced this pull request Mar 18, 2022
@pieh pieh moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Mar 18, 2022
pieh added a commit that referenced this pull request Mar 18, 2022
Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@pieh pieh moved this from Backport PR opened to Backported in V4 Release hotfixes Mar 18, 2022
@pieh pieh moved this from Backported to Published in V4 Release hotfixes Mar 18, 2022
@pieh
Copy link
Contributor

pieh commented Mar 18, 2022

Published in gatsby-cli@4.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants