fix(gatsby): fix api function compilation on Windows #38489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
2 tasks
pieh
added
topic: core
pieh
commented
Aug 28, 2023
| import type { LoaderDefinition } from "webpack" | ||
|
|
||
| const APIFunctionLoader: LoaderDefinition = async function () { | ||
| const params = new URLSearchParams(this.resourceQuery) | ||
| const matchPath = params.get(`matchPath`) | ||
|
|
||
| const modulePath = this.resourcePath | ||
| const modulePath = slash(this.resourcePath) |
There was a problem hiding this comment.
This just converts windows style file paths to unix one (so pretty much just \ -> /), as windows style paths routinely has troubles with \ escaping and unix style paths don't even have to deal with escaping problem
pieh
added
the
bot: merge on green
pieh
added a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 26feae4)
gatsbybot
pushed a commit
that referenced
this pull request
Aug 28, 2023
This was referenced Sep 23, 2023
This was referenced Oct 27, 2023
This was referenced Nov 3, 2023
This was referenced Nov 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes done to API functions compilation recently (part of adapters work) caused a regression where functions fail to compile correctly on Windows (due to path seperator / escape interaction). This converts windows style path to unix style path in a place where it cause a problem (better/safer to normalize to unix ones than trying to ensure appropiate escaping
\escaping is applied)Related Issues
Fixes #38481