Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: bump node version for pnp tests #38656

Merged
merged 2 commits into from
Oct 23, 2023
Merged

test: bump node version for pnp tests #38656

merged 2 commits into from
Oct 23, 2023

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Oct 23, 2023 •
edited

Description

With current setup and yesterday's release of Yarn 4 we get following in our pnp tests

Usage Error: This tool requires a Node version compatible with >=18.12.0 (got 18.0.0). Upgrade Node, or set `YARN_IGNORE_NODE=1` in your environment.

Yarn Package Manager - 4.0.0

  $ yarn <command>

You can also print more details about any of these commands by calling them with 
the `-h,--help` flag right after the command name.

Exited with code exit status 1

This just bumps node version when running Yarn PnP tests to allow to continue using and testing latest Yarn / berry

Documentation

Tests

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 23, 2023
@pieh pieh added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 23, 2023
@pieh pieh marked this pull request as ready for review October 23, 2023 11:47
@pieh pieh merged commit a6cc92f into master Oct 23, 2023
31 checks passed
@pieh pieh deleted the pieh-patch-2 branch October 23, 2023 13:38
@pieh pieh added this to To cherry-pick in V5 Release hotfixes via automation Oct 24, 2023
@pieh pieh moved this from To cherry-pick to Backport PR opened in V5 Release hotfixes Oct 24, 2023
@gatsbybot gatsbybot mentioned this pull request Oct 24, 2023
Merged
pieh added a commit that referenced this pull request Oct 24, 2023
@pieh
test: bump node version for pnp tests (#38656)
daed3d4 
* test: bump node version for pnp tests

* 18.12 not 18.2

(cherry picked from commit a6cc92f)
pieh added a commit that referenced this pull request Oct 25, 2023
@gatsbybot @pieh
test: bump node version for pnp tests (#38656) (#38663)
67c8832 
* test: bump node version for pnp tests

* 18.12 not 18.2

(cherry picked from commit a6cc92f)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@pieh pieh moved this from Backport PR opened to Backported in V5 Release hotfixes Oct 25, 2023
@pieh pieh moved this from Backported to Published in V5 Release hotfixes Oct 26, 2023
This was referenced Nov 17, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 22, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 29, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 6, 2024
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathmbeck kathmbeck kathmbeck approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
V5 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pieh @kathmbeck