Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused deps #7389

Merged
merged 2 commits into from
Aug 17, 2018
Merged

Remove unused deps #7389

merged 2 commits into from
Aug 17, 2018

Conversation

m-allanson
Copy link
Contributor

I am procrastinating.

m-allanson
m-allanson commented Aug 16, 2018
View reviewed changes
packages/gatsby/package.json
@@ -76,7 +74,6 @@
"graphql-tools": "^3.0.4",
"graphql-type-json": "^0.2.1",
"hash-mod": "^0.0.5",
"history": "^4.6.2",
"invariant": "^2.2.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need history any more, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aye

pieh
pieh approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@pieh pieh merged commit 524b9a1 into master Aug 17, 2018
@gatsbot
Copy link

gatsbot bot commented Aug 17, 2018

Fails
🚫

Danger failed to run /app/danger-0.hxyng09iaoi.ts.

Error VMError

Cannot find module '../utils/testable-schedule'
VMError: Cannot find module '../utils/testable-schedule'
    at _require (/app/node_modules/vm2/lib/sandbox.js:246:25)
    at Object.<anonymous> (/app/danger-0.hxyng09iaoi.ts:4:29)
    at NodeVM.run (/app/node_modules/vm2/lib/main.js:427:27)
    at Object.<anonymous> (/app/node_modules/danger/distribution/runner/runners/vm2.js:100:37)
    at step (/app/node_modules/danger/distribution/runner/runners/vm2.js:43:23)
    at Object.next (/app/node_modules/danger/distribution/runner/runners/vm2.js:24:53)
    at /app/node_modules/danger/distribution/runner/runners/vm2.js:18:71
    at new Promise (<anonymous>)
    at __awaiter (/app/node_modules/danger/distribution/runner/runners/vm2.js:14:12)
    at Object.exports.runDangerfileEnvironment (/app/node_modules/danger/distribution/runner/runners/vm2.js:83:121)

Dangerfile

----------------------------^

Generated by 🚫 dangerJS

porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
@m-allanson @porfirioribeiro
Remove unused deps (gatsbyjs#7389)
baa69cf 
* Remove unused deps

* Update lockfile
@m-allanson m-allanson deleted the remove-deps branch September 27, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews left review comments

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-allanson @KyleAMathews @pieh