Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrapRootElement in using-redux sample readme #7392

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Use wrapRootElement in using-redux sample readme #7392

merged 1 commit into from
Aug 17, 2018

Conversation

porfirioribeiro
Copy link
Contributor

This api changed, so the README

This api changed, so the README
@porfirioribeiro porfirioribeiro changed the title Use wrapRootElement in using-redux sampleR readme Use wrapRootElement in using-redux sample readme Aug 16, 2018
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pieh pieh merged commit 584468e into master Aug 17, 2018
@gatsbot
Copy link

gatsbot bot commented Aug 17, 2018

Fails
🚫

Danger failed to run /app/danger-0.poqq87o8zy.ts.

Error VMError

Cannot find module '../utils/testable-schedule'
VMError: Cannot find module '../utils/testable-schedule'
    at _require (/app/node_modules/vm2/lib/sandbox.js:246:25)
    at Object.<anonymous> (/app/danger-0.poqq87o8zy.ts:4:29)
    at NodeVM.run (/app/node_modules/vm2/lib/main.js:427:27)
    at Object.<anonymous> (/app/node_modules/danger/distribution/runner/runners/vm2.js:100:37)
    at step (/app/node_modules/danger/distribution/runner/runners/vm2.js:43:23)
    at Object.next (/app/node_modules/danger/distribution/runner/runners/vm2.js:24:53)
    at /app/node_modules/danger/distribution/runner/runners/vm2.js:18:71
    at new Promise (<anonymous>)
    at __awaiter (/app/node_modules/danger/distribution/runner/runners/vm2.js:14:12)
    at Object.exports.runDangerfileEnvironment (/app/node_modules/danger/distribution/runner/runners/vm2.js:83:121)

Dangerfile

----------------------------^

Generated by 🚫 dangerJS

porfirioribeiro added a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
@m-allanson m-allanson deleted the readmeupdate branch September 27, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants