Linking between pages doc #8626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonbux
added
the
type: documentation
There was a problem hiding this comment.
I think having this doc is very helpful -- not everyone is going to go through the tutorial. I have the same comment i've had recently though, which is that I'm not sure how helpful it is to include the entire code example from the tutorial -- it strikes me as unnecessarily duplicative.
I'd suggest:
- Intro language (which you have)
- A basic code block showing how to use the Link component (but not in a "step-by-step" guided kind of way.
- a link out to the full step-by-step example in the tutorial
Did you mean to link to the API docs twice? I'm not sure it's needed in the body of the doc, and at the end, but that's up to you! Lmk when you think.
How's this, @amberleyromo ?
|
@shannonbux I like the changes -- good to go, or still tweaking? |
|
Nevermind, saw your comment in the commit a99974a I think this is good, quick example and linking out to the longer tutorial explanation 👍 |
|
Awesome thanks @amberleyromo!
…On Mon, Oct 1, 2018 at 1:53 PM Amberley ***@***.***> wrote:
Merged #8626 <#8626> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8626 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Ae9o2rb1qTYiMiJHNhiPxxk8CTZf9tgpks5ugnLPgaJpZM4W_Z8i>
.
|
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wondering if the Gatsby Link doc (docs/gatsby-link/) is actually all we need? Not sure...