Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer server crash when deleting markdown directories #9211

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

goofytroopy
Copy link
Contributor

Deleting directory make gatsby crash. When working with markdownfiles and deleting a directory the developer server will crash. The same check that is for files should also be on directories, otherwise it might try to delete a directory that does not exist.

Deleting directory make gatsby crash. When working with markdownfiles and deleting a directory the developer server will crash. The same check that is for files should also be on directories, otherwise it might try to delete a directory that does not exist.
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good catch! Thanks @goofytroopy!

@m-allanson m-allanson merged commit 35eacd7 into gatsbyjs:master Oct 18, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 18, 2018

Holy buckets, @goofytroopy — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

jedrichards pushed a commit to jedrichards/gatsby that referenced this pull request Nov 1, 2018
Deleting directory make gatsby crash. When working with markdownfiles and deleting a directory the developer server will crash. The same check that is for files should also be on directories, otherwise it might try to delete a directory that does not exist.
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Deleting directory make gatsby crash. When working with markdownfiles and deleting a directory the developer server will crash. The same check that is for files should also be on directories, otherwise it might try to delete a directory that does not exist.
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
Deleting directory make gatsby crash. When working with markdownfiles and deleting a directory the developer server will crash. The same check that is for files should also be on directories, otherwise it might try to delete a directory that does not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants