fix(www): make DebounceInput value externally controlled #9292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Oct 24, 2018
www/src/components/debounce-input.js
Outdated
| this.setInputValue(this.props.value) | ||
| } | ||
|
|
||
| componentDidUpdate(prevProps, prevState, shouldFireRouteUpdate) { |
There was a problem hiding this comment.
prevState and shouldFireRouteUpdate are unused - can we remove them?
jedrichards
pushed a commit
to jedrichards/gatsby
that referenced
this pull request
Nov 1, 2018
* fix(www): make DebounceInput value externally controlled * remove unused parameters from DebounceInput
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
* fix(www): make DebounceInput value externally controlled * remove unused parameters from DebounceInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9244
Makes
DebounceInput's value externally controlled, which allows the parent component to change its value - eg. now we're clearing it on reset.