Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor typo corrections for gatsby-style-guide.md #9510

Merged
merged 3 commits into from
Oct 30, 2018
Merged

Minor typo corrections for gatsby-style-guide.md #9510

merged 3 commits into from
Oct 30, 2018

Conversation

tlent
Copy link
Contributor

@tlent tlent commented Oct 29, 2018

No description provided.

@tlent tlent requested a review from a team October 29, 2018 00:18
DSchau
DSchau reviewed Oct 29, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments!

docs/docs/gatsby-style-guide.md Outdated Show resolved Hide resolved
docs/docs/gatsby-style-guide.md Outdated Show resolved Hide resolved
@DSchau
Copy link
Contributor

DSchau commented Oct 30, 2018

@tlent once you've addressed/taken a look at that feedback, please let me know and I can take another look at merging; thanks!

@DSchau DSchau added the status: awaiting author response Additional information has been requested from the author label Oct 30, 2018
DSchau and others added 2 commits October 30, 2018 12:58
@DSchau @tlent
Add comma
a3cd6e3 
Co-Authored-By: tlent <tcl293@gmail.com>
@DSchau @tlent
Make sentence less wordy
e38b354 
Co-Authored-By: tlent <tcl293@gmail.com>
@tlent
Copy link
Contributor Author

tlent commented Oct 30, 2018

@DSchau Thanks for the suggestions I have just added them both

DSchau
DSchau approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the PR 💪

@DSchau DSchau merged commit ba5aa4d into gatsbyjs:master Oct 30, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 30, 2018

Holy buckets, @tlent — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

jedrichards pushed a commit to jedrichards/gatsby that referenced this pull request Nov 1, 2018
@tlent @jedrichards
Minor typo corrections for gatsby-style-guide.md (gatsbyjs#9510)
276c3a6
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@tlent @gpetrioli
Minor typo corrections for gatsby-style-guide.md (gatsbyjs#9510)
1fef2bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
status: awaiting author response Additional information has been requested from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tlent @DSchau