Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to tutorial part zero #9522

Merged
merged 17 commits into from
Nov 12, 2018
Merged

Improvements to tutorial part zero #9522

merged 17 commits into from
Nov 12, 2018

Conversation

tlent
Copy link
Contributor

@tlent tlent commented Oct 29, 2018

This PR:

  • Simplifies the headings and makes them more clear and consistent
  • Clarifies some of the sentences I thought might be confusing
  • Improves the summary at the end to cover everything done
  • Expands the Git section to better explain how to install it. I added links to the Atlassian guide for installing Git because I found they had the best explanations. The linked guides include a check that git is working so I did not include that.
  • Adds an optional link to learn more about Git and Github to the Git section and removes a later link serving the same purpose

@tlent tlent requested a review from a team October 29, 2018 14:47
@tlent tlent requested a review from a team as a code owner October 29, 2018 14:47
@amberleyromo
Copy link
Contributor

I'll leave this to @shannonbux to double-check the headings, but I think these changes make sense 👍

Copy link
Contributor

@yeskunall yeskunall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Thanks for this PR! It's great work! 💖


If your system does not have Git installed, install it from the [**Git downloads page**](https://git-scm.com/downloads).
> 💡 You will not need to use Git yourself to work with Gatsby, but it is a very useful tool to know about as a developer. If you are interested in learning more about version control, Git, and Github, check out Github's [Git Handbook](https://guides.github.com/introduction/git-handbook/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to make this change, then we also need to mention that git is used everywhere else when cloning gatsby-starters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, could you please clarify when Git is not necessary? It is necessary for many things people do with Gatsby, such as using starters and contributing to Gatsby.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point this sentence was not very clear. Hopefully the new version is better. The reason I have included it is to make sure nobody reading gets overwhelmed or too distracted by learning Git or all of its commands that the handbook talks about


## Install the Gatsby CLI
## The Gatsby CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "the" here is unnecessary. What I mean is, it adds no meaning. The Gatsby CLI would make sense in a world where this is the only Gatsby CLI ever. 😆

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right I have changed this title and other references to it to make it more clear that it is not the only Gatsby CLI

- title: Install the Gatsby CLI
link: /tutorial/part-zero/#install-the-gatsby-cli
- title: The command line
link: /tutorial/part-zero/#the-command-line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hyperlinks seem more disconnected to the doc/top we're talking about 🤔

Copy link
Contributor

@shannonbux shannonbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tlent! Lots of awesome edits here! Left a few requested changes. One overall change is to keep the word "install" in the headers that show up in the doc-links sidebar (so you'll have to leave the sidebar as is and then revert some of the changes in the doc itself. It's always a battle (in my mind) between making things shorter and making them clearer. Usually shorter = clearer; however, in this case the verbs help people know what to expect when they're scanning the sidebar.


If your system does not have Git installed, install it from the [**Git downloads page**](https://git-scm.com/downloads).
> 💡 You will not need to use Git yourself to work with Gatsby, but it is a very useful tool to know about as a developer. If you are interested in learning more about version control, Git, and Github, check out Github's [Git Handbook](https://guides.github.com/introduction/git-handbook/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, could you please clarify when Git is not necessary? It is necessary for many things people do with Gatsby, such as using starters and contributing to Gatsby.


## Install the Gatsby CLI
## The Gatsby CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree!


Now you can use the gatsby-cli tool to create your first Gatsby site. Using the tool, you can use “starters”, or partially built sites with some default configuration, to help you get moving faster on creating a certain type of site. The “Hello World” starter you’ll be using here is a starter with the bare essentials needed for a [Gatsby](/) site.
Now you are ready to use the Gatsby CLI tool to create your first Gatsby site. Using the Gatsby CLI you can download “starters” (partially built sites with some default configuration already done) to help you get moving faster on creating a certain type of site. The “Hello World” starter you’ll be using here is a starter with the bare essentials needed for a Gatsby site.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit wordy. Try "Now you are ready to use Gatsby CLI to create your first Gatsby site. Using the tool, you can download..."

And then remove the phrase "already done." Default configuration implies the same meaning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right I have made these changes in the new version


### ✋ Create a Gatsby site
### ✋ Create the site
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I like the previous heading more because it's clearer

@tlent
Copy link
Contributor Author

tlent commented Oct 30, 2018

Thank you for the feedback! I have reverted the heading changes to have verbs again and replied to the other suggestions above.


The command line is a text-based interface used to run commands on your computer. (You’ll also often see it referred to as the terminal. In this tutorial we’ll use both interchangeably). It’s a lot like using the Finder on a Mac, or Explorer on Windows. Finder and Explorer are examples of graphical user interfaces (GUI). The command line is a powerful, text-based way to interact with your computer.

### ✋ Familiarize yourself with the command line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably not be here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are following suite with the rest of the doc.

@shannonbux
Copy link
Contributor

shannonbux commented Nov 12, 2018

I edited the headers to streamline them and removed the emojis in headers for now. We could add them back in later. Thanks @tlent and @calcsam!

@shannonbux shannonbux merged commit 3fe6287 into gatsbyjs:master Nov 12, 2018
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
* Improved headers and clarity in tutorial part zero

* Further simplify headings

* Improve Git section

* Improve the summary

* Add optional link explaining git

* Remove other reference to learn about git

* Fix titles and links to match new headings

* Clarify that git only needs to be installed to use Gatsby

* Mention that the git handbook also explains Github

* Revert "Fix titles and links to match new headings"

This reverts commit 511bc37.

* Revert the headings back to having verbs

* Reword references to Gatsby CLI to make it clear it is not the only Gatsby CLI

* Change 'Create a Gatsby site' heading back

* Fix title to match heading

* Clarify git sentence

* Add missing space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants