Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(www): Containter component may have class: 'undefined'. #9537

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Fix(www): Containter component may have class: 'undefined'. #9537

merged 1 commit into from
Oct 30, 2018

Conversation

emtei
Copy link
Contributor

@emtei emtei commented Oct 29, 2018

Set className default value to be an empty string, so undefined won't appear in HTML code if className isn't passed in props.

@emtei emtei requested a review from a team as a code owner October 29, 2018 21:49
@pieh
Copy link
Contributor

pieh commented Oct 30, 2018

Is this (class="undefined") happening anywhere on gatsbyjs.org right now?

@emtei
Copy link
Contributor Author

emtei commented Oct 30, 2018

@pieh yes, i spotted it here:
https://www.gatsbyjs.org/docs/schema-generation/

image

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emtei!

@pieh pieh merged commit 795988b into gatsbyjs:master Oct 30, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 30, 2018

Holy buckets, @emtei — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

jedrichards pushed a commit to jedrichards/gatsby that referenced this pull request Nov 1, 2018
…#9537)

Set `className` default value to be an empty string, so `undefined` won't appear in HTML code if `className` isn't passed in props.
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…#9537)

Set `className` default value to be an empty string, so `undefined` won't appear in HTML code if `className` isn't passed in props.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants