Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add section on multiple layouts to gatsby-layout-plugin docs #9538

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

msachi
Copy link
Contributor

@msachi msachi commented Oct 29, 2018

Adding a section on how to use multiple layouts to gatsby-layout-plugin docs. Might be helpful to anyone trying to build a site with a more complex layout system (and who still needs to use or prefers the layout philosophy used in Gatsby v1).

@pieh
Copy link
Contributor

pieh commented Oct 30, 2018

I would move this to Troubleshooting section. This definitely need to be below v1 vs v2 explanation

@msachi
Copy link
Contributor Author

msachi commented Oct 30, 2018

No worries, have updated.

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msachi!

@pieh pieh changed the title Add section on multiple layouts to gatsby-layout-plugin docs docs: add section on multiple layouts to gatsby-layout-plugin docs Oct 30, 2018
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great; thank you!

@DSchau DSchau merged commit 6bbc4f0 into gatsbyjs:master Oct 30, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 30, 2018

Holy buckets, @msachi — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

jedrichards pushed a commit to jedrichards/gatsby that referenced this pull request Nov 1, 2018
…atsbyjs#9538)

Adding a section on how to use multiple layouts to gatsby-layout-plugin docs. Might be helpful to anyone trying to build a site with a more complex layout system (and who still needs to use or prefers the layout philosophy used in Gatsby v1).
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…atsbyjs#9538)

Adding a section on how to use multiple layouts to gatsby-layout-plugin docs. Might be helpful to anyone trying to build a site with a more complex layout system (and who still needs to use or prefers the layout philosophy used in Gatsby v1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants