Add content to placeholder descriptions on ecosystem landing page #9583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amberleyromo
commented
Oct 31, 2018
•
amberleyromo
commented
- Added content for the descriptions for all three content areas (plugins, starters, external resources)
|
@shannonbux would appreciate your eyes/approval. tried to make them all the same length! |
jedrichards
pushed a commit
to jedrichards/gatsby
that referenced
this pull request
Nov 1, 2018
…tsbyjs#9583) - Added content for the descriptions for all three content areas (plugins, starters, external resources) <img width="1549" alt="screen shot 2018-10-30 at 7 10 30 pm" src="https://user-images.githubusercontent.com/3461087/47758106-92634b80-dc77-11e8-9fa5-17b63ea9ef81.png">
shannonbux
reviewed
Nov 2, 2018
| @@ -55,7 +55,7 @@ const EcosystemBoard = ({ | |||
| /> | |||
| <EcosystemSection | |||
| title="External Resources" | |||
| description="More awesome Gatsby content, created by the community." | |||
| description="A curated list of interesting Gatsby community projects and learning resources like podcasts and tutorials." | |||
There was a problem hiding this comment.
I like that this is more specific than what existed before; it strikes me as just a bit long. What about getting rid of the word "interesting" (since that's a given :) and then making it into a list with commas, like "a curated list of Gatsby community projects, like podcasts, tutorials, and other learning resources"
Ok maybe that's longer now. I love commas, so sue me!
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…tsbyjs#9583) - Added content for the descriptions for all three content areas (plugins, starters, external resources) <img width="1549" alt="screen shot 2018-10-30 at 7 10 30 pm" src="https://user-images.githubusercontent.com/3461087/47758106-92634b80-dc77-11e8-9fa5-17b63ea9ef81.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.