-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gatsby): remove parsePath from gatsby core, and move to gatsby-link #9957
Merged
sidharthachatterjee
merged 9 commits into
gatsbyjs:master
from
DSchau:gatsby-link/parse-path
Feb 19, 2019
Merged
refactor(gatsby): remove parsePath from gatsby core, and move to gatsby-link #9957
sidharthachatterjee
merged 9 commits into
gatsbyjs:master
from
DSchau:gatsby-link/parse-path
Feb 19, 2019
Commits on Nov 15, 2018
-
refactor: remove parsePath from gatsby core, and move to gatsby-link
Moving a utility function (that was not used!) in gatsby core into where it belongs, gatsby-link. This was discovered via a community member (@travi), as he was attempting to use storybook to test a Link component (outside of Gatsby), e.g. `import Link from 'gatsby-link'`, which was then requiring `gatsby` core. This also generally solves some weirdness that the cyclical require was kinda weird, e.g. gatsby -> gatsby-link -> gatsby I do not believe this is a breaking change, since the version required of gatsby-link will just be bumped by gatsby, and the export is still exported from the top level gatsby module
Configuration menu - View commit details
-
Copy full SHA for 57a38f1 - Browse repository at this point
Copy the full SHA 57a38f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a851b - Browse repository at this point
Copy the full SHA 77a851bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7cecba - Browse repository at this point
Copy the full SHA a7cecbaView commit details
Commits on Feb 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3e6256b - Browse repository at this point
Copy the full SHA 3e6256bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf6eb21 - Browse repository at this point
Copy the full SHA cf6eb21View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd05819 - Browse repository at this point
Copy the full SHA bd05819View commit details
Commits on Feb 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c85fedb - Browse repository at this point
Copy the full SHA c85fedbView commit details
Commits on Feb 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for dbf53a9 - Browse repository at this point
Copy the full SHA dbf53a9View commit details
Commits on Feb 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d9671b5 - Browse repository at this point
Copy the full SHA d9671b5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.