Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow exclusion/inclusion of model terms in predicted_samples, etc #75

Closed
4 tasks done
gavinsimpson opened this issue Jun 5, 2020 · 2 comments
Closed
4 tasks done

Allow exclusion/inclusion of model terms in predicted_samples, etc #75

gavinsimpson opened this issue Jun 5, 2020 · 2 comments
Assignees
@gavinsimpson
Labels
enhancement New feature or request
Milestone
0.5

Comments

@gavinsimpson
Copy link
Owner

gavinsimpson commented Jun 5, 2020 •
edited
Loading

As per #74, allow for extra arguments to be passed to predict.gam() in

  • predicted_samples()
  • fitted_samples()
  • smooth_samples() (Not needed)

Check

  • What happens with type = "lpmatrix" if terms or exclude are passed to predict.gam()
@gavinsimpson gavinsimpson added the enhancement New feature or request label Jun 5, 2020
@gavinsimpson gavinsimpson added this to the 0.5 milestone Jun 5, 2020
@gavinsimpson gavinsimpson self-assigned this Jun 5, 2020
@gavinsimpson
Copy link
Owner Author

fitted_samples() already allowed ... to be passed to predict.gam() but should be checked how the type = "lpmatrix" case handles these to be sure that we do the right thing if some terms are excluded.

gavinsimpson added a commit that referenced this issue Jun 5, 2020
@gavinsimpson
allow additional arguments to be passed to predict.gam in predicted_s…
34bb7c3 
…amples() as per #75
gavinsimpson added a commit that referenced this issue Jun 5, 2020
@gavinsimpson
Merge branch 'issue-#75'; one part of #75
87e8c39
@gavinsimpson
Copy link
Owner Author

When type = "lpmatrix" is used, the columns of the prediction matrix get set to zero for terms not in terms or in exclude. So fitted_samples() is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinsimpson gavinsimpson

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@gavinsimpson