Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gon.request won't set #32

Closed
cj opened this issue Mar 19, 2012 · 5 comments
Closed

gon.request won't set #32

cj opened this issue Mar 19, 2012 · 5 comments

Comments

@cj
Copy link

cj commented Mar 19, 2012

Hi,

When I get gon.request = 'foo' it's no available in the view, but when doing gon.foo = 'bar' it works just fine.... could this be a possible bug?

@gazay
Copy link
Owner

gazay commented Mar 19, 2012

Hello! No, there should be an error rising if you try to use one of gon's public methods. Look https://github.com/gazay/gon/blob/master/lib/gon.rb#L47

@gazay gazay closed this as completed Mar 19, 2012
@cj
Copy link
Author

cj commented Mar 19, 2012

Thank you for getting back to me. Ah, makes sense. Strange I didn't get an error. (in development mode).

@gazay gazay reopened this Mar 19, 2012
@gazay
Copy link
Owner

gazay commented Mar 19, 2012

Oh. This make sense - I should write more tests for public methods - maybe there is some vulnerability of my gem. I'll write here later about status. Thank you for pointing me on this!)

@gazay
Copy link
Owner

gazay commented Mar 19, 2012

I'm talking about not getting error. I have one test for this case, but seems like this not enough. And people somehow can get information from gon methods. Maybe I should make this methods private

@gazay
Copy link
Owner

gazay commented Apr 17, 2012

I almost done refactoring of gon in branch "refactoring", so it will be fixed in new version

@gazay gazay closed this as completed Apr 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants