[Gazebo 9] Added test to check collisions equal to zero #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
mabelzhang
reviewed
Jul 18, 2020
There was a problem hiding this comment.
I tried the test, it passes, but it also passes when I reverted to the original code that produced the GUI bug before the change in https://github.com/osrf/gazebo/pull/2768/files .
I reverted Visual.cc lines 814-823 to the original lines 814-815. In GUI, when I do View > Collisions, I get
gzclient: /build/ogre-1.9-B6QkmW/ogre-1.9-1.9.0+dfsg1/OgreMain/src/OgreNode.cpp:630: virtual void Ogre::Node::setScale(const Ogre::Vector3&): Assertion `!inScale.isNaN() && "Invalid vector supplied as parameter"' failed.
Aborted (core dumped)
But the test is passing with this original version of code. So it is not exposing the bug.
gazebo/rendering/Visual_TEST.cc
Outdated
| @@ -1588,6 +1588,33 @@ TEST_F(Visual_TEST, ConvertVisualType) | |||
| rendering::Visual::ConvertVisualType(msgs::Visual::PHYSICS)); | |||
| } | |||
|
|
|||
| TEST_F(Visual_TEST, collisionZero) | |||
| { | |||
| // This test checks that there isn't a segmentation fault when inserting zero collision geometries | |||
There was a problem hiding this comment.
Code check is saying lines 1593 and 1594 should be < 80 chars long.
chapulina
reviewed
Jul 20, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
changed the title
|
Verified that now the test does fail with the error above when
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
Thank you @mabelzhang ! I got confused with the 100 characters per line in ROS |
|
Yeah I do that too. I don't even remember if ign-gazebo is 80 or 100. |
mabelzhang
approved these changes
Jul 22, 2020
ahcorde
added a commit
that referenced
this pull request
Jul 23, 2020
* Added test to check collisions equal to zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Included feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Update Visual_TEST.cc
ahcorde
added a commit
to ahcorde/gazebo
that referenced
this pull request
Jul 23, 2020
* Added test to check collisions equal to zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Included feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Update Visual_TEST.cc
ahcorde
added a commit
that referenced
this pull request
Jul 24, 2020
* Added test to check collisions equal to zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Included feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Update Visual_TEST.cc
ahcorde
added a commit
that referenced
this pull request
Jul 28, 2020
* Fixed crash when collision size is zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Using ignition::math::isnan Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved error message Signed-off-by: ahcorde <ahcorde@gmail.com> * fixed method to get the name of the visual Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed else brackets Signed-off-by: ahcorde <ahcorde@gmail.com> * [Gazebo 9] Added test to check collisions equal to zero (#2788) * Added test to check collisions equal to zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Included feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Update Visual_TEST.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed to add tests in this PR #2768.
I added a world with a box, sphere and cylinder with collisions equal to zero. The test will try to load the world, no segmentation fault should happens
Signed-off-by: ahcorde ahcorde@gmail.com