[Forwardport Gazebo 11] Added test to check collisions equal to zero (#2788) #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added test to check collisions equal to zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Included feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Update Visual_TEST.cc
mabelzhang
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Worked for me.
I tested by reverting #2770, saw that the test fails, then re-applying that PR, and saw that the test passes.
Looks like the buildfarm webpage is unresponsive again, so I can't see CI results. Since this PR is a forward port and only adding a new test, I think it's reasonable to say it shouldn't break other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwardport #2788
Signed-off-by: ahcorde ahcorde@gmail.com