[Gazebo9] Fixed fails for OSX: Added using namespace boost::placeholders #2809

ahcorde · 2020-07-30T13:15:15Z

Related with this issue #2808 (comment) and this error in the buildfarm https://build.osrfoundation.org/job/gazebo-ci-pr_any-homebrew-amd64/2057/console

Signed-off-by: Alejandro Hernández ahcorde@gmail.com

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

j-rivero · 2020-07-30T21:41:54Z

I still see some problems on the Mac build. Are they related to this PR?

/Users/jenkins/workspace/gazebo-ci-pr_any-homebrew-amd64/gazebo/test/plugins/ForceTorqueModelRemovalTestPlugin.cc:56:72: error: use of undeclared identifier '_1'
       boost::bind(&ForceTorqueModelRemovalTestPlugin::onUpdate, this, _1));

ahcorde · 2020-07-30T21:43:37Z

The compilation of the tests are failing. I'm trying to find a better solution

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

Signed-off-by: ahcorde <ahcorde@gmail.com>

scpeters

This looks good. I think an alternative would be to use std::bind instead of boost::bind, but this is more concise

gazebo/gui/model/ModelTreeWidget.cc

Signed-off-by: Louise Poubel <louise@openrobotics.org>

scpeters · 2020-08-08T15:03:57Z

ah, it looks like the Ubuntu builds are broken by the using namespace change.

I think we should either:

#if BOOST_VERSION > X instead of #idfef __APPLE__ (like in CommonIface.hh)
try using std::bind instead of boost::bind to see if that fixes it

scpeters · 2020-08-08T15:04:27Z

try using std::bind instead of boost::bind to see if that fixes it

I'm going to take a quick look at this to see if it's an easy fix

boost::bind changed its syntax for the placeholders, so just switch to std::bind and add a scoped using namespace std::placeholders to reduce the size of the diff. Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters · 2020-08-08T15:25:38Z

try using std::bind instead of boost::bind to see if that fixes it

I'm going to take a quick look at this to see if it's an easy fix

I took this approach in 5d3d06e; it's more than 3 lines per file, but it reduces our boost usage slightly without an unwieldy diff

scpeters · 2020-08-08T21:06:20Z

try using std::bind instead of boost::bind to see if that fixes it

I'm going to take a quick look at this to see if it's an easy fix

I took this approach in 5d3d06e; it's more than 3 lines per file, but it reduces our boost usage slightly without an unwieldy diff

it doesn't work for ubuntu though 🤭

Revert the previous change to std::bind. Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters · 2020-08-08T22:49:40Z

I switched to the other approach in fd718ac (#if BOOST_VERSION > X) and reduced the scope of the using namespace statement

ahcorde · 2020-08-10T07:02:25Z

thank you @scpeters for rework this PR 👍

j-rivero

Thanks @scpeters , @ahcorde . Looks good to me.

examples/stand_alone/custom_main_pkgconfig/CMakeLists.txt

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>

…ers (#2809) Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>

…ers (gazebosim#2809) Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>

…ers (#2809) Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>

Use patch from gazebosim/gazebo-classic#2809 Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Added using namespace boost::placeholders

6a8bc3a

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

ahcorde added the 9 Gazebo 9 label Jul 30, 2020

ahcorde requested review from j-rivero and chapulina July 30, 2020 13:15

ahcorde self-assigned this Jul 30, 2020

using namespace boost::placeholders; only on macos

95ef736

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

ahcorde added 2 commits July 31, 2020 09:34

Fixed test

d487059

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

Fixed custom main example

169402c

Signed-off-by: ahcorde <ahcorde@gmail.com>

scpeters approved these changes Aug 6, 2020

View reviewed changes

j-rivero approved these changes Aug 6, 2020

View reviewed changes

j-rivero requested changes Aug 6, 2020

View reviewed changes

gazebo/gui/model/ModelTreeWidget.cc Outdated Show resolved Hide resolved

j-rivero mentioned this pull request Aug 7, 2020

[Gazebo9] More enhancement for Windows build #2789

Merged

namespace on all platforms

16f1581

Signed-off-by: Louise Poubel <louise@openrobotics.org>

Use std::bind and scoped using statement

5d3d06e

boost::bind changed its syntax for the placeholders, so just switch to std::bind and add a scoped using namespace std::placeholders to reduce the size of the diff. Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Use boost namespace if version >= 1.73

fd718ac

Revert the previous change to std::bind. Signed-off-by: Steve Peters <scpeters@openrobotics.org>

ahcorde mentioned this pull request Aug 10, 2020

Mac Gazebo11 Catalina build fails at 79% osrf/homebrew-simulation#1081

Closed

traversaro mentioned this pull request Aug 10, 2020

Boost bind global placeholders warning when compiling against Boost 1.73 #2757

Closed

j-rivero approved these changes Aug 10, 2020

View reviewed changes

nunoguedelha mentioned this pull request Aug 10, 2020

GitHub Actions macOS build is failing robotology/robotology-superbuild#440

Closed

scpeters reviewed Aug 10, 2020

View reviewed changes

examples/stand_alone/custom_main_pkgconfig/CMakeLists.txt Outdated Show resolved Hide resolved

Update examples/stand_alone/custom_main_pkgconfig/CMakeLists.txt

cb26a97

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>

chapulina approved these changes Aug 11, 2020

View reviewed changes

chapulina merged commit c55942e into gazebo9 Aug 11, 2020

chapulina deleted the ahcorde/fix/boost branch August 11, 2020 01:03

j-rivero mentioned this pull request Aug 11, 2020

gazebo10 -> gazebo11 forward port #2816

Merged

scpeters added a commit to scpeters/homebrew-simulation that referenced this pull request Sep 15, 2020

gazebo9/10: patch for boost 1.73.0

f80f317

Use patch from gazebosim/gazebo-classic#2809 Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters mentioned this pull request Sep 15, 2020

gazebo9/10: patch for boost 1.73.0 osrf/homebrew-simulation#1128

Merged

scpeters added a commit to osrf/homebrew-simulation that referenced this pull request Sep 15, 2020

gazebo9/10: patch for boost 1.73.0 (#1128)

815ed71

Use patch from gazebosim/gazebo-classic#2809 Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters mentioned this pull request Jan 24, 2021

Merge 10 -> 11 #2923

Merged

This was referenced Jan 6, 2022

Suppress boost warnings about global placeholders #3147

Closed

Use boost/bind/bind.hpp to fix warnings on Arch Linux #3156

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gazebo9] Fixed fails for OSX: Added using namespace boost::placeholders #2809

[Gazebo9] Fixed fails for OSX: Added using namespace boost::placeholders #2809

ahcorde commented Jul 30, 2020

j-rivero commented Jul 30, 2020

ahcorde commented Jul 30, 2020

scpeters left a comment

scpeters commented Aug 8, 2020

scpeters commented Aug 8, 2020

scpeters commented Aug 8, 2020

scpeters commented Aug 8, 2020

scpeters commented Aug 8, 2020

ahcorde commented Aug 10, 2020

j-rivero left a comment

[Gazebo9] Fixed fails for OSX: Added using namespace boost::placeholders #2809

[Gazebo9] Fixed fails for OSX: Added using namespace boost::placeholders #2809

Conversation

ahcorde commented Jul 30, 2020

j-rivero commented Jul 30, 2020

ahcorde commented Jul 30, 2020

scpeters left a comment

Choose a reason for hiding this comment

scpeters commented Aug 8, 2020

scpeters commented Aug 8, 2020

scpeters commented Aug 8, 2020

scpeters commented Aug 8, 2020

scpeters commented Aug 8, 2020

ahcorde commented Aug 10, 2020

j-rivero left a comment

Choose a reason for hiding this comment