Fix light preview parameters #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
ahcorde
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Thank you for the fix,
Regarding the inner/outer angles tests, Adding new methods don't break API, I think it's fine to add them, @chapulina or @scpeters Do you agree?
scpeters
reviewed
Jun 29, 2021
There was a problem hiding this comment.
Regarding the inner/outer angles tests, Adding new methods don't break API, I think it's fine to add them, @chapulina or @scpeters Do you agree?
you are welcome to add getters for inner and outer angles if you like
…t GUI creation. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
|
I added the getters and added a test for spotlight creation which utilizes the getters. |
chapulina
approved these changes
Dec 30, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
New test passed on CI, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2981 . See the issue for detailed description.
lights_fixed.mp4
I also wanted to add tests for the inner/outer angle, but they have no getters. Should I add these? Please, also check that the copy of
lightI make in the test is actually still a pointer to the preview light and is not pointing to the same objectlightdoes at the end of the test. I think it should be so, but another pair of eyes would be good :)