Fix compatibility with FFmpeg 5.0 #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you so much for fixing this in both ign-common and here in gazebo! I still see two deprecation warnings for |
This was referenced Apr 19, 2022
scpeters
approved these changes
May 25, 2022
4 tasks
This was referenced Oct 6, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial backport of:
to Classic Gazebo.
With respect to gazebosim/gz-common#325, I noticed a strange behaviour for which the
avcodec_parameters_to_contextfunction that in https://github.com/osrf/gazebo/pull/3195/files#diff-08c8dfc0ffe4733c2fcc1ebd0e3f67032e24b302b25a90c26e87994582503198R326 was not copying the members of theAVCodecParametersstructure to theAVCodecContextstructure. I was not able to understand why that happened, but copying the members manually worked fine, however it is probably worth to check that the tests work fine on another setup by commenting out https://github.com/osrf/gazebo/pull/3195/files#diff-08c8dfc0ffe4733c2fcc1ebd0e3f67032e24b302b25a90c26e87994582503198R334-R348 .