[ffmpeg] Update to 5.0 #23312

Sibras · 2022-02-28T00:39:59Z

[ffmpeg] Updated to 5.0 release.

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-02-28T06:29:13Z

@Sibras ,Thanks for your pr, looks CI tested failed in many triplet,
Please take a look:
https://dev.azure.com/vcpkg/public/_build/results?buildId=68078&view=artifacts&pathAsName=false&type=publishedArtifacts

Sibras · 2022-02-28T10:01:48Z

The errors in the CI were unfortunately somewhat expected.
ffmpeg builds fine but several other packages fail due to ffmpeg 5.0 removing older deprecated API. So any project that hasnt updated accordingly now fails to compile.

From the CI the current packages that only work with ffmpeg 4.x and not 5.x are:
aubio
avcpp
ignition
opencv4
pangolin

These projects would need to be fixed or possibly do one of those unwanted but perhaps necessary dual ffmpeg ports.

cenit · 2022-02-28T11:14:28Z

add also opencv2 and opencv3 that are not tested by CI (which for compatibility reasons tests only opencv4) but are still used anyway

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout e6509c997fef840f7cfdb84cf6e757b70ee283a8 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/f-/ffmpeg.json b/versions/f-/ffmpeg.json
index dfb11fa..f13931e 100644
--- a/versions/f-/ffmpeg.json
+++ b/versions/f-/ffmpeg.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "89a620b10d38c235afa130f17d59503035bcb1d5",
+      "git-tree": "e5fb0b01f935d3afb92285ba6ad1279c49a36878",
       "version": "5.0.0",
       "port-version": 0
     },

JonLiu1993 · 2022-03-11T10:25:03Z

@Sibras ,Is this pr temporarily blocked?

Sibras · 2022-03-12T03:22:56Z

@Sibras ,Is this pr temporarily blocked?

Yep, I put it up so that people who want ffmpeg 5.0 know how to do it. But until a solution is provided to fix the downstream projects that are not compatible with 5.0 this PR is blocked.

Not sure what the best solution is to proceed. Either create a separate ffmpeg5 port, wait for some of those dependent projects to be fixed (some havnt been maintained for years so this is unlikely, opencv2/3 also unlikely to get fixed). Or have some way for dependency ports to specify what port versions (min/max) they support.

JonLiu1993 · 2022-03-18T09:13:23Z

Because of blocking, temporarily convert this pr to draft

ghesketh · 2022-04-24T14:40:19Z

@Sibras ,Is this pr temporarily blocked?

Yep, I put it up so that people who want ffmpeg 5.0 know how to do it. But until a solution is provided to fix the downstream projects that are not compatible with 5.0 this PR is blocked.

Not sure what the best solution is to proceed. Either create a separate ffmpeg5 port, wait for some of those dependent projects to be fixed (some havnt been maintained for years so this is unlikely, opencv2/3 also unlikely to get fixed). Or have some way for dependency ports to specify what port versions (min/max) they support.

It seems like creating a new package (e.g., ffmpeg5) would be consistent with historical vcpkg practices, such as with opencv, sdl, etc.

traversaro · 2022-04-24T23:00:18Z

For Gazebo and ignition we have patches upstream:

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for ffmpeg but no changes to version or port version.
-- Version: 5.0.0
-- Old SHA: 89a620b10d38c235afa130f17d59503035bcb1d5
-- New SHA: 6f361162d526d0dfa3843d54372e49d3c1b4bd99
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

horenmar · 2022-06-14T13:51:43Z

For the record, newer versions of opencv should also support ffmpeg 5.

cenit · 2022-06-16T09:57:39Z

i will try to back port support also to older version if reasonable

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for ignition-cmake2 have changed but the version was not updated
version: 2.16.0
old SHA: 1e94a4739cf0e6197a67fbd5770cbff1afcf5f51
new SHA: e0229e6592e49e38cbd38efd2fdd2e7bfe6dbadb
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for ffmpeg have changed but the version was not updated
version: 5.0.0
old SHA: 63dd066e60c32d9e3ac36f821cf905affa1ba04b
new SHA: 91fa777293991dcc9d6c4043184ebdabcb606f4e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for ignition-math6 have changed but the version was not updated
version: 6.9.2
old SHA: 6ba12e1d6fbb4b7b72e209a4dad9b3bf0ec83879
new SHA: 4e2aee16ba73208b597a3207829db009dab93775
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

JonLiu1993 · 2022-12-30T09:37:24Z

versions/f-/ffmpeg.json

-      "git-tree": "0a71b1f5734a3ead9f3941a4fae62aeeede10681",
-      "version": "4.4.3",
-      "port-version": 2


@Sibras, Don't change the history "git-tree", please add new one.

Fixed, got messed up in one of the many upstream merges.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for ffmpeg have changed but the version was not updated
version: 5.0.0
old SHA: 91fa777293991dcc9d6c4043184ebdabcb606f4e
new SHA: f9ec761c4698e9009ab1b2fcf9f8a59ce5995bde
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Sibras · 2022-12-31T14:46:38Z

All dependent ports have now been updated in master, this PR is now good to go.

vicroms · 2023-01-03T18:32:35Z

Thanks for all the hard work!

[ffmpeg] Update to 5.0 (microsoft#23312)

Sibras added 2 commits February 28, 2022 11:35

[ffmpeg] Update to 5.0

cfe6510

update versions

5918a85

github-actions bot approved these changes Feb 28, 2022

View reviewed changes

FrankXie05 assigned JonLiu1993 Feb 28, 2022

JonLiu1993 linked an issue Feb 28, 2022 that may be closed by this pull request

[ffmpeg] update to 5.0 #23217

Closed

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 28, 2022

JonLiu1993 added the requires:author-response label Feb 28, 2022

JonLiu1993 removed the requires:author-response label Mar 3, 2022

Merge branch 'master' into master

99f71cc

github-actions bot requested changes Mar 11, 2022

View reviewed changes

JonLiu1993 added the requires:author-response label Mar 11, 2022

JonLiu1993 removed the requires:author-response label Mar 14, 2022

ReenigneArcher mentioned this pull request Mar 18, 2022

FFMPEG dependency update LizardByte/Sunshine#44

Closed

JonLiu1993 marked this pull request as draft March 18, 2022 09:13

Sibras added 2 commits April 16, 2022 19:19

Fix after merge.

672a85e

ffmpeg: Fix lzma debug lib naming.

15bde9c

Merge remote-tracking branch 'upstream/master'

b1a1756

github-actions bot requested changes May 7, 2022

View reviewed changes

Update ffmpeg.json

d89a9b9

github-actions bot approved these changes May 7, 2022

View reviewed changes

JonLiu1993 previously approved these changes Dec 23, 2022

View reviewed changes

JonLiu1993 added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Dec 23, 2022

Merge branch 'master' into master

56f8a9c

Sibras dismissed stale reviews from JonLiu1993 and github-actions[bot] via 56f8a9c December 29, 2022 04:52

github-actions bot requested changes Dec 29, 2022

View reviewed changes

Update versions.

238a4af

github-actions bot previously approved these changes Dec 29, 2022

View reviewed changes

Merge branch 'master' into master

14062bf

Sibras dismissed github-actions[bot]’s stale review via 14062bf December 30, 2022 08:00

github-actions bot previously approved these changes Dec 30, 2022

View reviewed changes

JonLiu1993 requested changes Dec 30, 2022

View reviewed changes

Update ffmpeg.json

f2189fd

Sibras dismissed github-actions[bot]’s stale review via f2189fd December 30, 2022 13:33

github-actions bot previously approved these changes Dec 30, 2022

View reviewed changes

Merge branch 'master' into master

59cd100

Sibras dismissed github-actions[bot]’s stale review via 59cd100 December 31, 2022 14:40

github-actions bot requested changes Dec 31, 2022

View reviewed changes

Update ffmpeg.json

38f774d

github-actions bot approved these changes Dec 31, 2022

View reviewed changes

JonLiu1993 approved these changes Jan 3, 2023

View reviewed changes

vicroms merged commit 0f719b3 into microsoft:master Jan 3, 2023

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jan 4, 2023

Merge pull request #1245 from microsoft/master

85b1ab3

[ffmpeg] Update to 5.0 (microsoft#23312)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ffmpeg] Update to 5.0 #23312

[ffmpeg] Update to 5.0 #23312

Sibras commented Feb 28, 2022 •

edited

Loading

github-actions bot left a comment

JonLiu1993 commented Feb 28, 2022

Sibras commented Feb 28, 2022

cenit commented Feb 28, 2022

github-actions bot left a comment

JonLiu1993 commented Mar 11, 2022

Sibras commented Mar 12, 2022

JonLiu1993 commented Mar 18, 2022

ghesketh commented Apr 24, 2022

traversaro commented Apr 24, 2022

github-actions bot left a comment

horenmar commented Jun 14, 2022

cenit commented Jun 16, 2022

github-actions bot left a comment

JonLiu1993 Dec 30, 2022

Sibras Dec 30, 2022

github-actions bot left a comment

Sibras commented Dec 31, 2022

vicroms commented Jan 3, 2023

[ffmpeg] Update to 5.0 #23312

[ffmpeg] Update to 5.0 #23312

Conversation

Sibras commented Feb 28, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Feb 28, 2022

Sibras commented Feb 28, 2022

cenit commented Feb 28, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Mar 11, 2022

Sibras commented Mar 12, 2022

JonLiu1993 commented Mar 18, 2022

ghesketh commented Apr 24, 2022

traversaro commented Apr 24, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

horenmar commented Jun 14, 2022

cenit commented Jun 16, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 Dec 30, 2022

Choose a reason for hiding this comment

Sibras Dec 30, 2022

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Sibras commented Dec 31, 2022

vicroms commented Jan 3, 2023

Sibras commented Feb 28, 2022 •

edited

Loading