👩🌾 Disable tests that initialize App on macOS: they're all flaky #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Louise Poubel louise@openrobotics.org
🦟 Bug workaround
See #123
Summary
All the tests that initialize an
App
have been flaky onign-gui4
even though they consistently pass onign-gui3
(#123). I've tried a few different things to debug this with no luck.Since we're not likely to have time to address these issues soon, I'm going to disable those tests so we don't pollute CI results with tests that are known to flake.
Our macOS CI uses a higher version of Qt than our Linux CI. So problems on macOS often let us know of upcoming problems on Linux. So commenting out these tests could just be pushing the problem down the road.
Checklist
Updated documentation (as needed)Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
https://github.com/osrf/buildfarmer/issues/156