👩‍🌾 Disable tests that initialize App on macOS: they're all flaky

[chapulina]

Signed-off-by: Louise Poubel louise@openrobotics.org

🦟 Bug workaround

See #123

Summary

All the tests that initialize an App have been flaky on ign-gui4 even though they consistently pass on ign-gui3 (#123). I've tried a few different things to debug this with no luck.

Since we're not likely to have time to address these issues soon, I'm going to disable those tests so we don't pollute CI results with tests that are known to flake.

Our macOS CI uses a higher version of Qt than our Linux CI. So problems on macOS often let us know of upcoming problems on Linux. So commenting out these tests could just be pushing the problem down the road.

Checklist

• Signed all commits for DCO
• Added tests - more like removed 😄
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

---

https://github.com/osrf/buildfarmer/issues/156

[codecov]

Codecov Report

Merging #184 (5437444) into ign-gui4 (56bb6b3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           ign-gui4     #184   +/-   ##
=========================================
  Coverage     60.77%   60.77%           
=========================================
  Files            21       21           
  Lines          2840     2840           
=========================================
  Hits           1726     1726           
  Misses         1114     1114           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56bb6b3...5437444. Read the comment docs.

[j-rivero]

Probably out of the scope of this PR but github actions is failing with:

  [ RUN      ] ApplicationTest.LoadDefaultConfig
  [GUI] [Wrn] [Application.cc:649] [QT] could not connect to display :1.0
  [GUI] [Err] [Application.cc:653] [QT] This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
  
  Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, xcb.
  
  
        Start  2: check_UNIT_Application_TEST
   2/32 Test  #2: check_UNIT_Application_TEST ............***Failed    0.03 sec

I did not find any issue created for this or if we want to fix it or disable it somehow in github actions.

[chapulina]

I thought I had sent this message yesterday, but it was still here 😬

github actions is failing with

Failing? I don't see any failures 😇 I re-ran the tests, those ones are flaky, see #58