-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New teleop plugin implementation. #245
Conversation
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
I will review it, in the meantime @LolaSegura is working on the tests |
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #245 +/- ##
============================================
+ Coverage 65.71% 66.46% +0.74%
============================================
Files 23 25 +2
Lines 2835 2949 +114
============================================
+ Hits 1863 1960 +97
- Misses 972 989 +17
Continue to review full report at Codecov.
|
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
The first iteration is done. I haven't review the test file yet.
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
ffa7aee
to
ebbf1b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! That's a lot of features!
@LolaSegura Nice Job!: Some general comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some more comments mainly related to the test file.
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
07a98de
to
b8bccc0
Compare
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
b8bccc0
to
f953516
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!, I left some nits!
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looking good! I pushed some changes in 8328a17 which I hope will fix the Windows build.
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: LolaSegura lsegura@ekumenlabs.com
🎉 New feature
Closes #186
Summary
The user can insert the GUI teleop plugin in a world that has a vehicle and setting a desire topic, can send commands by pressing buttons, using the keyboard or with sliders.
Test it
You can test it loading a world in ignition gazebo that has a vehicle like
ign gazebo diff_drive_skid.sdf
, selecting the Teleop plugin, configuring the desired topic to send the twist commands,/model/vehicle_blue/cmd_vel
.OpenPlugin.mp4
To try the buttons, you have to set the desired linear and angular velocity and then click on the direction buttons. More than one button can be selected in order to rotate while moving forward or backward.
To try the keyboard, first you have to enable it by clicking on the "keyboard" switch. The keys are W, A, D, X.
To use the sliders you have to enable them by clicking on the "Sliders" switch. The maximum and minimum velocity are configurable.
MovingCar.mp4
Checklist
codecheck
passed (See contributing)