Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inserting WorldControl and WorldStats from menu #349

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Currently, if WorldControl or WorldStats are inserted from the menu, they don't display anything and are therefore unusable. That's because all their elements are optional and hidden by default (which we should consider changing).

This PR works around that by displaying all widgets if no elements are passed onto the plugin. The assumption is that the user would never want to hide all elements at the same time.

With this PR, these plugins can be inserted from the menu and they work with Gazebo:

world_gui_from_menu

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added bug Something isn't working OOBE 📦✨ Out-of-box experience labels Jan 14, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 14, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #349 (3b92495) into ign-gui3 (297d565) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 3b92495 differs from pull request most recent head 85b539c. Consider uploading reports for the commit 85b539c to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui3     #349      +/-   ##
============================================
+ Coverage     67.71%   67.79%   +0.08%     
============================================
  Files            28       28              
  Lines          3110     3118       +8     
============================================
+ Hits           2106     2114       +8     
  Misses         1004     1004              
Impacted Files Coverage Δ
src/plugins/world_control/WorldControl.cc 80.00% <100.00%> (+0.51%) ⬆️
src/plugins/world_stats/WorldStats.cc 97.29% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297d565...85b539c. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Jan 15, 2022
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor comment

src/plugins/world_control/WorldControl.hh Show resolved Hide resolved
@chapulina chapulina merged commit a6afb94 into ign-gui3 Jan 19, 2022
@chapulina chapulina deleted the chapulina/3/world_from_menu branch January 19, 2022 00:26
Core development automation moved this from In review to Done Jan 19, 2022
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants