-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve inserting WorldControl and WorldStats from menu #349
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #349 +/- ##
============================================
+ Coverage 67.71% 67.79% +0.08%
============================================
Files 28 28
Lines 3110 3118 +8
============================================
+ Hits 2106 2114 +8
Misses 1004 1004
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a minor comment
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
🦟 Bug fix
Summary
Currently, if
WorldControl
orWorldStats
are inserted from the menu, they don't display anything and are therefore unusable. That's because all their elements are optional and hidden by default (which we should consider changing).This PR works around that by displaying all widgets if no elements are passed onto the plugin. The assumption is that the user would never want to hide all elements at the same time.
With this PR, these plugins can be inserted from the menu and they work with Gazebo:
Checklist
Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸