-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Dialogs to have a MainWindow independent config #418
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #418 +/- ##
============================================
+ Coverage 66.12% 66.42% +0.29%
============================================
Files 29 29
Lines 3218 3291 +73
============================================
+ Hits 2128 2186 +58
- Misses 1090 1105 +15
Continue to review full report at Codecov.
|
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
I had to comment the test here , until someone could give me some feedback, as I couldn't figure out why it was failing |
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The motivation for this PR is, all the current reading/writing of the Config is implemented in MainWindow, and the Application has not been initialized yet then there is not MainWindow object.
I'm not sure I understand this part. The application has to be initialized before the dialog. Can't we use leave the config path handling to the Application
? It would be nice if we didn't need another config file and could reuse the same one. The <dialog>
elements could be siblings of the <window>
element.
Have you seen the WindowConfig
struct? That's used to hold an in-memory representation of an XML config file, load from a file and write to it. It would be interesting to follow the same pattern for consistency of the API, creating a new DialogConfig
struct.
Signed-off-by: Mohamad <mohamad@openrobotics.org>
… into quick_setup_menu_config
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Updated the PR per VC, except of using templates with |
0f57c1f
to
cc72807
Compare
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
Signed-off-by: Mohamad <mohamad@openrobotics.org>
@chapulina green 👍 |
Signed-off-by: Mohamad mohamad@openrobotics.org
🎉 New feature
This PR allows Dialogs to read and write to the config file.
The motivation for this PR is, all the current reading/writing of the
Config
is implemented inMainWindow
, and the Application has not been initialized yet then there is notMainWindow
object.a dialog config looks like
<dialog name=\"dialog_name\" attribute_1=\"true\"/>"
Workflow:
SetName
SetDefaultConfig
ReadAttribute
5. append the dialog default config to the config file
6. read from the written config
WriteAttributre
The changes here are used in this PR.
Summary
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.