Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on python3-yaml instead of python-yaml #153

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Jammy doesn't have python-yaml. If python3-yaml works with Bionic and Focal, we should use that.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig as a code owner March 30, 2022 17:36
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #153 (c07a135) into ign-launch5 (7dbac66) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-launch5     #153   +/-   ##
============================================
  Coverage        32.92%   32.92%           
============================================
  Files                4        4           
  Lines              817      817           
============================================
  Hits               269      269           
  Misses             548      548           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dbac66...c07a135. Read the comment docs.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 30, 2022
@chapulina chapulina merged commit 9cbc15e into ign-launch5 Mar 30, 2022
@chapulina chapulina deleted the chapulina/5/python3 branch March 30, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants