Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Numerically Equal and Relatively Equal comparisons in math helper class #43

Open
osrf-migration opened this issue Apr 4, 2016 · 1 comment
Labels
enhancement New feature or request

Comments

@osrf-migration
Copy link

Original report (archived issue) by John Hsu (Bitbucket: hsu, GitHub: hsu).


Current comparison strategy math::equal is using primitive absolute magnitude comparison. This may not be sufficient in some cases, for example where relative magnitudes are large, or the values being compared border numerical precision boundaries.

Per @sherm1 recommendation in pull request #82, we should add math::numericallyEqual and math::relativelyEqual.

Also, see issue #42 for extension to Vector3 class.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • Edited issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants