-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Equal tolerance method to Quaternion #196
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-math6 #196 +/- ##
=============================================
- Coverage 99.20% 99.20% -0.01%
=============================================
Files 63 63
Lines 6020 6019 -1
=============================================
- Hits 5972 5971 -1
Misses 48 48
Continue to review full report at Codecov.
|
1eff96d
to
8be4e08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
8be4e08
to
4bb6f57
Compare
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
4bb6f57
to
05e5232
Compare
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
05e5232
to
1e9ce65
Compare
Signed-off-by: Ashton Larkin ashton@openrobotics.org
🎉 New feature
Summary
I've added a method to compare equality between quaternions with a user-defined tolerance, similar to the Vector3 class. This is useful in cases where the default precision of the quaternion's
==
operator (.001) isn't enough, such as in gazebosim/gz-physics#223 (since physics requires high precision, 1e-6 is used for equality tolerance instead of 1e-3).Test it
Take a look at the unit tests written in this PR (files changed tab ->
src/Quaternion_TEST.cc
).Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge