Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Stopwatch test sleep times #326

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Reduce Stopwatch test sleep times #326

merged 1 commit into from
Dec 21, 2021

Conversation

mjcarroll
Copy link
Contributor

Takes this test from over 18 seconds to less than 1 second on my computer, while still maintain the same coverage.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #326 (0b7481b) into main (3c96971) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          67       67           
  Lines        6077     6077           
=======================================
  Hits         6033     6033           
  Misses         44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c96971...0b7481b. Read the comment docs.

Core development automation moved this from Inbox to In review Dec 21, 2021
@mjcarroll mjcarroll merged commit 132b0e4 into main Dec 21, 2021
@mjcarroll mjcarroll deleted the shorter_stopwatch branch December 21, 2021 17:46
Core development automation moved this from In review to Done Dec 21, 2021
mjcarroll added a commit that referenced this pull request Dec 22, 2021
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants