Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoogleTest to latest version #435

Merged
merged 8 commits into from
Jun 28, 2022
Merged

Update GoogleTest to latest version #435

merged 8 commits into from
Jun 28, 2022

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented May 31, 2022

Import latest version of GoogleTest from upstream and adjust build accordingly.

Signed-off-by: Michael Carroll michael@openrobotics.org

@osrf-triage osrf-triage added this to Inbox in Core development May 31, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 31, 2022
@mjcarroll mjcarroll marked this pull request as ready for review May 31, 2022 15:37
@mjcarroll mjcarroll requested a review from scpeters as a code owner May 31, 2022 15:37
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #435 (68fc596) into main (0919a13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          73       73           
  Lines        6567     6567           
=======================================
  Hits         6547     6547           
  Misses         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0919a13...68fc596. Read the comment docs.

Core development automation moved this from Inbox to In review May 31, 2022
@mjcarroll
Copy link
Contributor Author

I'm going to hold off and see if there are any more changes uncovered when doing the other libraries.

@chapulina
Copy link
Contributor

Would it be possible to target this at ign-math6? I'm working on some tests that only pass with these changes 😬

@mjcarroll
Copy link
Contributor Author

I'm working on some tests that only pass with these changes.

Likely yes, but what kind of tests out of curiosity?

@chapulina chapulina moved this from In review to In progress in Core development Jun 13, 2022
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit d15c9b2 into main Jun 28, 2022
Core development automation moved this from In progress to Done Jun 28, 2022
@mjcarroll mjcarroll deleted the bump_gtest branch June 28, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants