Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aditya as codeowner (backport to ign-math6 branch) #443

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

adityapande-1995
Copy link
Contributor

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Summary

Added Aditya as a codeowner, backport of #440

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@osrf-triage osrf-triage added this to Inbox in Core development Jun 20, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jun 20, 2022
@scpeters
Copy link
Member

would you please add the sign-off message?

Signed-off-by: Aditya <aditya050995@gmail.com>
@adityapande-1995
Copy link
Contributor Author

Sorry about that, I edited using the Github GUI and missed the signoff.

Core development automation moved this from Inbox to In review Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #443 (e7368b3) into ign-math6 (49c3915) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           ign-math6     #443      +/-   ##
=============================================
- Coverage      99.83%   99.65%   -0.18%     
=============================================
  Files             41       67      +26     
  Lines           4138     6392    +2254     
=============================================
+ Hits            4131     6370    +2239     
- Misses             7       22      +15     
Impacted Files Coverage Δ
...all/include/ignition/math6/ignition/math/Sphere.hh
...include/ignition/math6/ignition/math/detail/Box.hh
...ll/include/ignition/math6/ignition/math/Matrix3.hh
...ignition/math6/ignition/math/MovingWindowFilter.hh
...ude/ignition/math6/ignition/math/AxisAlignedBox.hh
...all/include/ignition/math6/ignition/math/Filter.hh
.../include/ignition/math6/ignition/math/Triangle3.hh
...clude/ignition/math6/ignition/math/SpeedLimiter.hh
...tall/include/ignition/math6/ignition/math/Angle.hh
...tall/include/ignition/math6/ignition/math/Pose3.hh
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c3915...e7368b3. Read the comment docs.

@scpeters scpeters merged commit 73b23d1 into ign-math6 Jun 20, 2022
Core development automation moved this from In review to Done Jun 20, 2022
@scpeters scpeters deleted the adityapande-1995-patch-1 branch June 20, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants