More test data

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
gazebosim · Mar 8, 2024 · fbe8627 · fbe8627
1 parent 4f257e3
commit fbe8627
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/test/desc/testing.invalid b/test/desc/testing.invalid
@@ -0,0 +1,8 @@
+syntax = "proto3";
+
+package testing;
+
+message Bytes
+{
+  bytes data    = 1;
+}
diff --git a/test/desc/testing.proto b/test/desc/testing.proto
@@ -0,0 +1,8 @@
+syntax = "proto3";
+
+package testing;
+
+message Bytes
+{
+  bytes data    = 1;
+}
diff --git a/test/integration/descriptors.cc b/test/integration/descriptors.cc
@@ -43,7 +43,19 @@ TEST(FactoryTest, DynamicFactory)
   EXPECT_EQ(nullptr, gz::msgs::Factory::New("testing.BarMessage"));
   EXPECT_EQ(nullptr, gz::msgs::Factory::New("testing.BazMessage"));
 
-  // Test loading an empty file
+  // Test loading an incorrect extension
+  {
+    std::filesystem::path test_path(kMsgsTestPath);
+    std::string paths = (test_path / "desc" / "testing.invalid").string();
+    gz::msgs::Factory::LoadDescriptors(paths);
+  }
+  EXPECT_EQ(nullptr, gz::msgs::Factory::New("example.msgs.StringMsg"));
+  EXPECT_EQ(nullptr, gz::msgs::Factory::New("testing.Bytes"));
+  EXPECT_EQ(nullptr, gz::msgs::Factory::New("testing.FooMessage"));
+  EXPECT_EQ(nullptr, gz::msgs::Factory::New("testing.BarMessage"));
+  EXPECT_EQ(nullptr, gz::msgs::Factory::New("testing.BazMessage"));
+
+  // Test loading a file with invalid content
   {
     std::filesystem::path test_path(kMsgsTestPath);
     std::string paths = (test_path / "desc" / "testing.proto").string();
@@ -80,5 +92,4 @@ TEST(FactoryTest, DynamicFactory)
   EXPECT_NE(nullptr, gz::msgs::Factory::New("testing.FooMessage"));
   EXPECT_NE(nullptr, gz::msgs::Factory::New("testing.BarMessage"));
   EXPECT_NE(nullptr, gz::msgs::Factory::New("testing.BazMessage"));
-
 }