Few clangtidy fixes #343
Few clangtidy fixes #343
Conversation
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
| @@ -220,7 +220,7 @@ namespace gz | |||
| #endif // _WIN32 | |||
|
|
|||
| ////////////////////////////////////////////////// | |||
| const std::string separator(const std::string &_p) | |||
There was a problem hiding this comment.
return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
| @@ -149,7 +149,7 @@ bool Generator::Generate(const FileDescriptor *_file, | |||
|
|
|||
| auto ns = getNamespaces(_file->package()); | |||
|
|
|||
| for (auto name : ns) | |||
There was a problem hiding this comment.
loop variable is copied but only used as const reference; consider making it a const reference
| @@ -25,8 +25,6 @@ namespace google { | |||
| namespace protobuf { | |||
| namespace compiler { | |||
| namespace cpp { | |||
| class GeneratorContext; | |||
There was a problem hiding this comment.
declaration 'GeneratorContext' is never referenced, but a declaration with the same name found in another namespace 'proto2::compiler'
Codecov Report
@@ Coverage Diff @@
## gz-msgs9 #343 +/- ##
=========================================
Coverage 95.41% 95.41%
=========================================
Files 10 10
Lines 1026 1026
=========================================
Hits 979 979
Misses 47 47
|
No description provided.