Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id and visibility_flags to Projector msg fields #345

Merged
merged 1 commit into from
May 23, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 22, 2023

🎉 New feature

Closes #341

Summary

Adding a couple of fields to projector msg

  • id: Unique entity id
  • visibility_flags: If the projector's visibility flags matches a camera's visibility_mask, then the projector will be visible to the camera.

Related todo note in gz-sim: https://github.com/gazebosim/gz-sim/blob/gz-sim7/src/Conversions.cc#L1790

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from caguero as a code owner May 22, 2023 22:25
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 22, 2023
@osrf-triage osrf-triage added this to Inbox in Core development May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #345 (63c661a) into main (cfe6c2e) will not change coverage.
The diff coverage is n/a.

❗ Current head 63c661a differs from pull request most recent head dfbcef3. Consider uploading reports for the commit dfbcef3 to get more accurate results

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files          10       10           
  Lines        1030     1030           
=======================================
  Hits          983      983           
  Misses         47       47           

Core development automation moved this from Inbox to In review May 23, 2023
@mjcarroll mjcarroll merged commit 61188ea into main May 23, 2023
12 checks passed
Core development automation moved this from In review to Done May 23, 2023
@mjcarroll mjcarroll deleted the projector_fields branch May 23, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants