Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet-featherstone Added detachable joints #428

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 26, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Bullet-featherstone Added detachable joints

detachable

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 26, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Sep 26, 2022
@mjcarroll mjcarroll moved this from Inbox to In review in Core development Sep 26, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #428 (05fdcc6) into add-bullet-featherstone (a5b2f7d) will increase coverage by 0.27%.
The diff coverage is 97.87%.

@@                     Coverage Diff                     @@
##           add-bullet-featherstone     #428      +/-   ##
===========================================================
+ Coverage                    69.85%   70.13%   +0.27%     
===========================================================
  Files                          139      139              
  Lines                         6871     6918      +47     
===========================================================
+ Hits                          4800     4852      +52     
+ Misses                        2071     2066       -5     
Impacted Files Coverage Δ
bullet-featherstone/src/JointFeatures.cc 40.25% <97.61%> (+21.50%) ⬆️
bullet-featherstone/src/Base.hh 100.00% <100.00%> (ø)
...ullet-featherstone/src/EntityManagementFeatures.cc 21.71% <0.00%> (+2.63%) ⬆️
bullet-featherstone/src/SimulationFeatures.cc 100.00% <0.00%> (+5.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
bullet-featherstone/src/JointFeatures.cc Outdated Show resolved Hide resolved
bullet-featherstone/src/JointFeatures.cc Outdated Show resolved Hide resolved
dartsim/src/SimulationFeatures.cc Outdated Show resolved Hide resolved
test/common_test/joint_features.cc Show resolved Hide resolved
test/common_test/joint_features.cc Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@mjcarroll mjcarroll merged commit ffda143 into add-bullet-featherstone Sep 29, 2022
Core development automation moved this from In review to Done Sep 29, 2022
@mjcarroll mjcarroll deleted the ahcorde/add-bullet-featherstone/detachable_joints branch September 29, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants